Skip to content

SIMD Barycentric Evaluation and Test #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: graphite-base/1069
Choose a base branch
from

Conversation

Gali-StarkWare
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Gali-StarkWare commented Apr 29, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


crates/prover/src/core/poly/circle/evaluation.rs line 249 at r1 (raw file):

// TODO(Gali): Remove.
#[allow(dead_code)]
fn simd_weights(

This function should have unit test

Code quote:

fn simd_weights(

@Gali-StarkWare Gali-StarkWare changed the base branch from gali/cpu_barycentric to graphite-base/1069 May 14, 2025 07:23
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: ce3c080 Previous: 8b5436d Ratio
iffts/simd ifft/24 67115643 ns/iter (± 6856175) 33238741 ns/iter (± 2455518) 2.02

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

@Gali-StarkWare Gali-StarkWare force-pushed the gali/simd_barycentric branch from baac125 to ce3c080 Compare May 14, 2025 07:47
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/1069 to gali/cpu_barycentric May 14, 2025 07:47
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 20 lines in your changes missing coverage. Please review.

Project coverage is 92.67%. Comparing base (bb9e718) to head (ce3c080).

Files with missing lines Patch % Lines
crates/prover/src/core/poly/circle/evaluation.rs 85.71% 20 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           graphite-base/1069    #1069      +/-   ##
======================================================
- Coverage               92.70%   92.67%   -0.04%     
======================================================
  Files                     106      106              
  Lines                   14409    14548     +139     
  Branches                14409    14548     +139     
======================================================
+ Hits                    13358    13482     +124     
- Misses                    970      985      +15     
  Partials                   81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gali-StarkWare Gali-StarkWare changed the base branch from gali/cpu_barycentric to graphite-base/1069 May 14, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants