-
Notifications
You must be signed in to change notification settings - Fork 130
SIMD Barycentric Evaluation and Test #1069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: graphite-base/1069
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bdbf71c
to
baac125
Compare
8a83a9f
to
92a5086
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
crates/prover/src/core/poly/circle/evaluation.rs
line 249 at r1 (raw file):
// TODO(Gali): Remove. #[allow(dead_code)] fn simd_weights(
This function should have unit test
Code quote:
fn simd_weights(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2
.
Benchmark suite | Current: ce3c080 | Previous: 8b5436d | Ratio |
---|---|---|---|
iffts/simd ifft/24 |
67115643 ns/iter (± 6856175 ) |
33238741 ns/iter (± 2455518 ) |
2.02 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @shaharsamocha7
92a5086
to
bb9e718
Compare
baac125
to
ce3c080
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## graphite-base/1069 #1069 +/- ##
======================================================
- Coverage 92.70% 92.67% -0.04%
======================================================
Files 106 106
Lines 14409 14548 +139
Branches 14409 14548 +139
======================================================
+ Hits 13358 13482 +124
- Misses 970 985 +15
Partials 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.