Skip to content

chore!: Revert opentelemetry bump with Jaeger removal #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 5, 2024

Description

In #830 the Jaeger TracingTarget was removed (as we though it's not used), so that we can bump the opentelemetry crates.
However, some concerns where raised, so we revert the bump and will re-visit it later

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer changed the title Revert "chore!: Dependency bumps (#830)" Revert opentelemetry bump with Jaeger removal Aug 5, 2024
@sbernauer sbernauer changed the title Revert opentelemetry bump with Jaeger removal chore!: Revert opentelemetry bump with Jaeger removal Aug 5, 2024
@nightkr
Copy link
Member

nightkr commented Aug 5, 2024

Probably want to remove the stale changelog entry too

@sbernauer
Copy link
Member Author

Sorry, what entry are you referring to?

@sbernauer
Copy link
Member Author

The one added in #830 get's removed here

@nightkr
Copy link
Member

nightkr commented Aug 5, 2024

Right, my bad. I was looking for the top-level CHANGELOG.md.

@sbernauer sbernauer added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 0e44ef2 Aug 5, 2024
20 checks passed
@sbernauer sbernauer deleted the revert/jaeger-removal branch August 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants