Skip to content

chore!: Remove Jaeger support #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 5, 2024
Merged

chore!: Remove Jaeger support #830

merged 7 commits into from
Aug 5, 2024

Conversation

sbernauer
Copy link
Member

Description

https://crates.io/crates/opentelemetry-jaeger stopped pushing new versions, so we can either:

  1. Rip out Jaeger support (in favor of otlp)
  2. Don't update the whole opentelemetry ecosystem

As the removal of Jaeger was planned in any case and I'm not aware of any Jaeger usage (in operator-rs, not talking about webhook and co.), I would prefer the first.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer self-assigned this Aug 5, 2024
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 5, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I just had to see what the .tracer(...) was doing, but I see they switched from returning a Result<Tracer, _> to a Result<TracerProvider, _>, hence the addition to get the Tracer.

@sbernauer sbernauer requested a review from NickLarsenNZ August 5, 2024 09:34
@sbernauer sbernauer requested review from NickLarsenNZ and removed request for NickLarsenNZ August 5, 2024 10:12
@sbernauer sbernauer added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 5185439 Aug 5, 2024
20 checks passed
@sbernauer sbernauer deleted the chore/bumps-2 branch August 5, 2024 10:25
@nightkr
Copy link
Member

nightkr commented Aug 5, 2024

Wait.. so we don't support any opentelemetry target at all now then? Is there anything blocking OTLP support? Was there a pressing need for this upgrade? Doesn't removing the exporter support remove what impetus there was for upgrading the dependency?

Also please try to actually describe the change in the PR title. Removing a feature is not a "dependency bump".

@nightkr nightkr changed the title chore!: Dependency bumps Remove Jaeger support Aug 5, 2024
@sbernauer
Copy link
Member Author

Honestly I don't have answers to those questions, what do you think of reverting the opentelemetry bump?
Yes, the PR title is bad, it spiraled out, sorry!

@sbernauer sbernauer changed the title Remove Jaeger support chore!: Remove Jaeger support Aug 5, 2024
@nightkr
Copy link
Member

nightkr commented Aug 5, 2024

Yeah I would hold it back for now and make an issue about migrating.

sbernauer added a commit that referenced this pull request Aug 5, 2024
@sbernauer
Copy link
Member Author

Makes sense, please have a look at #832

github-merge-queue bot pushed a commit that referenced this pull request Aug 5, 2024
* Revert "chore!: Dependency bumps (#830)"

This reverts commit 5185439.

* bump other crates again
@sbernauer sbernauer mentioned this pull request Aug 9, 2024
@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Aug 9, 2024

For future reference, I would have liked to be involved in this conversation (and the decision to do #832). Somehow I missed any notifications for it.

IMO, we should remove opentelemetry-jaeger, as it is deprecated. It doesn't mean Jaeger can't be used, but tracing should be transported via OTLP (which Jaeger supports).

I propose we:

  1. Deprecate this initialize_logging function (see 2).
  2. Upgrade operators to use the new stackable-telemetry initialisation (which replaces the functionality in 1).
  3. With the removal of the logging function, opentelemetry-jaeger will be gone and will not hold us back from future opentelemetry version bumps.

Edit: By involved, I meant on the revert of this PR. Somehow I missed the @ mention, so that's on me. I'm happy to receive slack messages.

@Techassi
Copy link
Member

Techassi commented Aug 9, 2024

I agree with @NickLarsenNZ's comment and would have also liked to be involved since he and I worked on the stackable-telemetry crate which is the next step towards better telemetry via OpenTelemetry (and OLTP).

This change is especially weird, because it was done during simple dependency bumps.

@NickLarsenNZ
Copy link
Member

This change is especially weird, because it was done during simple dependency bumps.

Just for clarity, the dependency bump is not compatible with jaeger anymore, hence it being dropped.

@sbernauer
Copy link
Member Author

@NickLarsenNZ and I talked about this and are happy to talk to you @Techassi when you are back :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants