-
-
Notifications
You must be signed in to change notification settings - Fork 15
chore!: Remove Jaeger support #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I just had to see what the .tracer(...)
was doing, but I see they switched from returning a Result<Tracer, _>
to a Result<TracerProvider, _>
, hence the addition to get the Tracer
.
Wait.. so we don't support any opentelemetry target at all now then? Is there anything blocking OTLP support? Was there a pressing need for this upgrade? Doesn't removing the exporter support remove what impetus there was for upgrading the dependency? Also please try to actually describe the change in the PR title. Removing a feature is not a "dependency bump". |
Honestly I don't have answers to those questions, what do you think of reverting the opentelemetry bump? |
Yeah I would hold it back for now and make an issue about migrating. |
Makes sense, please have a look at #832 |
For future reference, I would have liked to be involved in this conversation (and the decision to do #832). Somehow I missed any notifications for it. IMO, we should remove I propose we:
Edit: By involved, I meant on the revert of this PR. Somehow I missed the @ mention, so that's on me. I'm happy to receive slack messages. |
I agree with @NickLarsenNZ's comment and would have also liked to be involved since he and I worked on the This change is especially weird, because it was done during simple dependency bumps. |
Just for clarity, the dependency bump is not compatible with jaeger anymore, hence it being dropped. |
@NickLarsenNZ and I talked about this and are happy to talk to you @Techassi when you are back :) |
Description
https://crates.io/crates/opentelemetry-jaeger stopped pushing new versions, so we can either:
As the removal of Jaeger was planned in any case and I'm not aware of any Jaeger usage (in operator-rs, not talking about webhook and co.), I would prefer the first.
Definition of Done Checklist