sap_software_download: New role for downloading software #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Executing
sap_launchpad
modules require initial setup of environment, Python modules, etc.This all can be moved into role, which will do this work so we can remove it from our other playbooks.
We also have need for additional handling and logic that would be unnecessary in modules themselves.
Additional logic on top of modules
sap_software_download_use_venv: false
sap_software_download_find_alternatives: true
sap_software_download_files
at same time.sap_software_download_validate_relationships: true
sap_software_download_ignore_relationship_warning
,sap_software_download_ignore_file_not_found
,sap_software_download_ignore_plan_not_found
Testing
Testing is being done on localhost as well as managed node, with both Python venv and default Python.
Download latest files:
Download SAP HANA files and validate their versions: This will trigger warnings due to mismatch, but they will be ignored because of
sap_software_download_ignore_relation_warning
.Note commented out files, which is way to trigger warning as they were not found.
Download files but also transaction at same time