Skip to content

all: Replace sap_launchpad tasks with new role sap_software_download #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

marcelmamula
Copy link
Collaborator

Description

PR continues from #52, by replacing tasks related to sap_launchpad role and its prerequisites by new role sap_launchpad.sap_download_software sap-linuxlab/community.sap_launchpad#32.

This also includes removal of include_tasks for Interactive file that does not exist.

ansible-lint is almost clear with this removal:

risky-shell-pipe: Shells that use pipes should set the pipefail option.
deploy_scenarios/sap_ecc_ibmdb2_distributed_ha/ansible_playbook.yml:739

Redesign details

Changes are based on #45

@marcelmamula marcelmamula added the enhancement New feature or request label Apr 4, 2025
@marcelmamula marcelmamula self-assigned this Apr 4, 2025
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@marcelmamula marcelmamula merged commit 1cb22d4 into sap-linuxlab:dev Apr 7, 2025
1 check passed
@marcelmamula marcelmamula deleted the launchpad_replace branch April 7, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants