Skip to content

all: Update all scenarios with new fragments and new workflow #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 28, 2025

Conversation

marcelmamula
Copy link
Collaborator

Description

PR continues from #55, by:

  • All scenario extravars are split into fragments
    • _base that contains scenario specific variables
    • _spec that contains host specification
  • Playbook is updated to:
  • Replaced hana and swpm dictionaries (sap_swpm_templates_install_dictionary) with one common for both sap_software_install_dictionary in order to simplify playbooks
    • Move wildcards into sap_software_install_dictionary
    • Move distributed system entries one level lower so we can make lookup easier - all will be under product, not product+group
  • Added comments to all variables in extravars files

All files are getting proper review with Ansible Lint without all ignores we currently have.

Redesign details

Changes are based on #45

@marcelmamula marcelmamula added the enhancement New feature or request label Apr 15, 2025
@marcelmamula marcelmamula self-assigned this Apr 15, 2025
@marcelmamula marcelmamula requested a review from sean-freeman May 19, 2025 14:54
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified code, lgtm 👍

@sean-freeman
Copy link
Member

Final commits look good to me 👍

@marcelmamula marcelmamula merged commit 0322940 into sap-linuxlab:dev May 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants