Skip to content

all: Complete overhaul with new Interactive Mode, variable fragments, publishing automation and updated playbooks #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
May 28, 2025

Conversation

marcelmamula
Copy link
Collaborator

Description

This pull request is major overhaul of whole repository in order to create base for simpler updates using publishing automation.
All changes originate from original proof of concept #45.

Changes

all: Add fragments with Interactive prompts, platform images and vars #57

  • New Interactive Mode supporting all non-experimental platforms and scenarios. Full documentation is present at common_fragments/tasks/interactive/README.md
  • New folder common_fragments that will be used for re-used variables and tasks, shared across all scenarios.
  • New platform variable fragments for separate management of OS images and Platform variables.

Add github action for publishing stage to main #58

  • New github action automation that will be used for distributing common_fragments across scenarios.

all: Update all scenarios with new fragments and new workflow #59

  • All scenario extravars are split into fragments
    • _base that contains scenario specific variables
    • _spec that contains host specification
  • Playbook is updated to:
  • Replaced hana and swpm dictionaries (sap_swpm_templates_install_dictionary) with one common for both sap_software_install_dictionary in order to simplify playbooks
    • Move wildcards into sap_software_install_dictionary
    • Move distributed system entries one level lower so we can make lookup easier - all will be under product, not product+group
  • Added comments to all variables in extravars files

Test Results

All scenarios were tested on SLES 15 SP6 on AWS with exception of sap_ecc_ibmdb2_distributed_ha which needs some work as documented in #60

All scenarios were tested along with recent improvements that are not released yet!

@marcelmamula marcelmamula requested a review from sean-freeman May 28, 2025 14:04
@marcelmamula marcelmamula self-assigned this May 28, 2025
@marcelmamula marcelmamula added documentation Improvements or additions to documentation enhancement New feature or request labels May 28, 2025
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 for creation of new branch stage

@marcelmamula marcelmamula merged commit a2fad7e into stage May 28, 2025
2 checks passed
github-actions bot pushed a commit that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants