-
Notifications
You must be signed in to change notification settings - Fork 15
Add devcontainers #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-25.08
Are you sure you want to change the base?
Add devcontainers #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally support adding these here, thanks! If this works, fine with me to merge.
I am running into problems solving the conda environment in rapidsai/rapidsmpf#301 because the `rapids-dependency-file-generator` is too old. This updates it.
@bdice I filed this PR to fix the issue with the older version of DFG, but I noticed the current behavior worked in rapidsai/devcontainers#519. I'm curious, what changed in newer DFG versions to make it generate CUDA 12.8 dependencies even though |
I made basically the same change in this PR. I'm generating only 12.8 environments. We concluded that we didn't want to have developer environments for CUDA 12.9 anywhere in RAPIDS until we resolve the blocking build issue we saw for CUDA 12.9 with cudf, so I changed the environments in this PR from 12.9 to 12.8. |
I'll rebase this once #318 goes in. |
@@ -1,6 +1,16 @@ | |||
# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. | |||
# See file LICENSE for terms. | |||
|
|||
[tool.codespell] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit run --all-files
fails for me without this configuration. The failure is:
.devcontainer/README.md:3: implementors ==> implementers
But that's a proper name in that file, so it's not a typo.
rapidsai/devcontainers#523 should fix the pip failures here. I'll retry in a bit. |
Any idea why the pip devcontainers can't |
I thought we fixed that in rapidsai/ucxx#429 But that has definitely been a problem |
Pulling in changes from the default branch to see if that resolves the issue -- I think we should already have the updated configs in place, but it's worth a shot |
@gforsyth when I configure locally with
Does rapidsmpf need to augment FindPackage when searching for C++ libraries in a virtual env? |
Huh, well, I'm not clear on why the rest of the |
The CMake package files are located somewhere else in conda vs. pip. Is this the first package that's attempting to |
I think it is. The |
@gforsyth I succesfully configured in a venv by augmenting $ configure-rapidsmpf-cpp \
-Wno-dev \
-DBUILD_BENCHMARKS=ON \
-DBUILD_TESTS=OFF \
-DCMAKE_PREFIX_PATH="$(sp="$(python -c 'import site; print(site.getsitepackages()[0])')"; declare -a ar="($(echo "$sp"/{libcudf,rapids_logger,librmm,libucxx}/lib{,64}/cmake))"; IFS=';'; echo "${ar[*]}")" The expression above expands to: $ echo "$(sp="$(python -c 'import site; print(site.getsitepackages()[0])')"; declare -a ar="($(echo "$sp"/{libcudf,rapids_logger,librmm,libucxx}/lib{,64}/cmake))"; IFS=';'; echo "${ar[*]}")"
/home/coder/.local/share/venvs/rapids/lib/python3.13/site-packages/libcudf/lib/cmake;/home/coder/.local/share/venvs/rapids/lib/python3.13/site-packages/libcudf/lib64/cmake;/home/coder/.local/share/venvs/rapids/lib/python3.13/site-packages/rapids_logger/lib/cmake;/home/coder/.local/share/venvs/rapids/lib/python3.13/site-packages/rapids_logger/lib64/cmake;/home/coder/.local/share/venvs/rapids/lib/python3.13/site-packages/librmm/lib/cmake;/home/coder/.local/share/venvs/rapids/lib/python3.13/site-packages/librmm/lib64/cmake;/home/coder/.local/share/venvs/rapids/lib/python3.13/site-packages/libucxx/lib/cmake;/home/coder/.local/share/venvs/rapids/lib/python3.13/site-packages/libucxx/lib64/cmake There's probably a way to do this in CMake, but would need to use |
Adds rapidsmpf devcontainers.