-
Notifications
You must be signed in to change notification settings - Fork 15
Add devcontainers #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bdice
wants to merge
3
commits into
rapidsai:branch-25.08
Choose a base branch
from
bdice:add-devcontainers
base: branch-25.08
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add devcontainers #301
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # syntax=docker/dockerfile:1.5 | ||
|
|
||
| ARG BASE | ||
| ARG PYTHON_PACKAGE_MANAGER=conda | ||
|
|
||
| FROM ${BASE} as pip-base | ||
|
|
||
| ENV DEFAULT_VIRTUAL_ENV=rapids | ||
|
|
||
| FROM ${BASE} as conda-base | ||
|
|
||
| ENV DEFAULT_CONDA_ENV=rapids | ||
|
|
||
| FROM ${PYTHON_PACKAGE_MANAGER}-base | ||
|
|
||
| ARG CUDA | ||
| ENV CUDAARCHS="RAPIDS" | ||
| ENV CUDA_VERSION="${CUDA_VERSION:-${CUDA}}" | ||
|
|
||
| ARG PYTHON_PACKAGE_MANAGER | ||
| ENV PYTHON_PACKAGE_MANAGER="${PYTHON_PACKAGE_MANAGER}" | ||
|
|
||
| ENV PYTHONSAFEPATH="1" | ||
| ENV PYTHONUNBUFFERED="1" | ||
| ENV PYTHONDONTWRITEBYTECODE="1" | ||
|
|
||
| ENV SCCACHE_REGION="us-east-2" | ||
| ENV SCCACHE_BUCKET="rapids-sccache-devs" | ||
| ENV AWS_ROLE_ARN="arn:aws:iam::279114543810:role/nv-gha-token-sccache-devs" | ||
| ENV HISTFILE="/home/coder/.cache/._bash_history" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # RapidsMPF Development Containers | ||
|
|
||
| This directory contains [devcontainer configurations](https://containers.dev/implementors/json_reference/) for using VSCode to [develop in a container](https://code.visualstudio.com/docs/devcontainers/containers) via the `Remote Containers` [extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) or [GitHub Codespaces](https://github.com/codespaces). | ||
|
|
||
| This container is a turnkey development environment for building and testing the RapidsMPF C++ and Python libraries. | ||
|
|
||
| ## Table of Contents | ||
|
|
||
| * [Prerequisites](#prerequisites) | ||
| * [Host bind mounts](#host-bind-mounts) | ||
| * [Launch a Dev Container](#launch-a-dev-container) | ||
|
|
||
| ## Prerequisites | ||
|
|
||
| * [VSCode](https://code.visualstudio.com/download) | ||
| * [VSCode Remote Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) | ||
|
|
||
| ## Host bind mounts | ||
|
|
||
| By default, the following directories are bind-mounted into the devcontainer: | ||
|
|
||
| * `${repo}:/home/coder/rapidsmpf` | ||
| * `${repo}/../.aws:/home/coder/.aws` | ||
| * `${repo}/../.local:/home/coder/.local` | ||
| * `${repo}/../.cache:/home/coder/.cache` | ||
| * `${repo}/../.conda:/home/coder/.conda` | ||
| * `${repo}/../.config:/home/coder/.config` | ||
|
|
||
| This ensures caches, configurations, dependencies, and your commits are persisted on the host across container runs. | ||
|
|
||
| ## Launch a Dev Container | ||
|
|
||
| To launch a devcontainer from VSCode, open the RapidsMPF repo and select the "Reopen in Container" button in the bottom right:<br/><img src="https://user-images.githubusercontent.com/178183/221771999-97ab29d5-e718-4e5f-b32f-2cdd51bba25c.png"/> | ||
|
|
||
| Alternatively, open the VSCode command palette (typically `cmd/ctrl + shift + P`) and run the "Rebuild and Reopen in Container" command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "build": { | ||
| "context": "${localWorkspaceFolder}/.devcontainer", | ||
| "dockerfile": "${localWorkspaceFolder}/.devcontainer/Dockerfile", | ||
| "args": { | ||
| "CUDA": "12.8", | ||
| "PYTHON_PACKAGE_MANAGER": "conda", | ||
| "BASE": "rapidsai/devcontainers:25.08-cpp-mambaforge-ubuntu22.04" | ||
| } | ||
| }, | ||
| "runArgs": [ | ||
| "--rm", | ||
| "--name", | ||
| "${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-25.08-cuda12.8-conda" | ||
| ], | ||
| "hostRequirements": {"gpu": "optional"}, | ||
| "features": { | ||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils:25.8": {} | ||
| }, | ||
| "overrideFeatureInstallOrder": [ | ||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils" | ||
| ], | ||
| "initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config,conda/pkgs,conda/${localWorkspaceFolderBasename}-cuda12.8-envs}"], | ||
| "postAttachCommand": ["/bin/bash", "-c", "if [ ${CODESPACES:-false} = 'true' ]; then . devcontainer-utils-post-attach-command; . rapids-post-attach-command; fi"], | ||
| "workspaceFolder": "/home/coder", | ||
| "workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/rapidsmpf,type=bind,consistency=consistent", | ||
| "mounts": [ | ||
| "source=${localWorkspaceFolder}/../.aws,target=/home/coder/.aws,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.cache,target=/home/coder/.cache,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.config,target=/home/coder/.config,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.conda/pkgs,target=/home/coder/.conda/pkgs,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.conda/${localWorkspaceFolderBasename}-cuda12.8-envs,target=/home/coder/.conda/envs,type=bind,consistency=consistent" | ||
| ], | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "ms-python.flake8", | ||
| "nvidia.nsight-vscode-edition" | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "build": { | ||
| "context": "${localWorkspaceFolder}/.devcontainer", | ||
| "dockerfile": "${localWorkspaceFolder}/.devcontainer/Dockerfile", | ||
| "args": { | ||
| "CUDA": "12.8", | ||
| "PYTHON_PACKAGE_MANAGER": "pip", | ||
| "BASE": "rapidsai/devcontainers:25.08-cpp-cuda12.8-ucx1.18.0-openmpi5.0.7-ubuntu22.04" | ||
| } | ||
| }, | ||
| "runArgs": [ | ||
| "--rm", | ||
| "--name", | ||
| "${localEnv:USER:anon}-rapids-${localWorkspaceFolderBasename}-25.08-cuda12.8-pip" | ||
| ], | ||
| "hostRequirements": {"gpu": "optional"}, | ||
| "features": { | ||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils:25.8": {} | ||
| }, | ||
| "overrideFeatureInstallOrder": [ | ||
| "ghcr.io/rapidsai/devcontainers/features/rapids-build-utils" | ||
| ], | ||
| "initializeCommand": ["/bin/bash", "-c", "mkdir -m 0755 -p ${localWorkspaceFolder}/../.{aws,cache,config/pip,local/share/${localWorkspaceFolderBasename}-cuda12.8-venvs}"], | ||
| "postAttachCommand": ["/bin/bash", "-c", "if [ ${CODESPACES:-false} = 'true' ]; then . devcontainer-utils-post-attach-command; . rapids-post-attach-command; fi"], | ||
| "workspaceFolder": "/home/coder", | ||
| "workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/rapidsmpf,type=bind,consistency=consistent", | ||
| "mounts": [ | ||
| "source=${localWorkspaceFolder}/../.aws,target=/home/coder/.aws,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.cache,target=/home/coder/.cache,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.config,target=/home/coder/.config,type=bind,consistency=consistent", | ||
| "source=${localWorkspaceFolder}/../.local/share/${localWorkspaceFolderBasename}-cuda12.8-venvs,target=/home/coder/.local/share/venvs,type=bind,consistency=consistent" | ||
| ], | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "ms-python.flake8", | ||
| "nvidia.nsight-vscode-edition" | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit run --all-filesfails for me without this configuration. The failure is:But that's a proper name in that file, so it's not a typo.