Skip to content

Update rapids-dependency-file-generator #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 23, 2025

I am running into problems solving the conda environment in rapidsai/rapidsmpf#301 because the rapids-dependency-file-generator is too old. This updates it.

@bdice bdice requested a review from a team as a code owner May 23, 2025 01:02
@bdice bdice requested review from jameslamb and removed request for a team May 23, 2025 01:02
@bdice
Copy link
Contributor Author

bdice commented May 23, 2025

This was pinned in #344 / #361 but no reason for the pinning was given.

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason for the pinning was given

Based on the timing and the specific version in the ceiling, I suspect it was a result of rapidsai/dependency-file-generator#100

All RAPIDS repos were updated to account for that in 24.08 (including this repo, in #322, as part of rapidsai/dependency-file-generator#89), but maybe the pin was added because there were people using newer devcontainers with older RAPIDS versions.

If I'm right about why this pin was here, it should be fine to remove it now... I'd be surprised to learn anyone would need to use the 25.08 devcontainers to build RAPIDS 24.06 or older.

Copy link
Collaborator

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update feature version

@bdice bdice requested a review from trxcllnt May 23, 2025 18:34
@bdice
Copy link
Contributor Author

bdice commented May 23, 2025

Thanks @jameslamb, that makes sense to me. I can confirm this newer version is working in rapidsai/rapidsmpf#301.

Also thanks for the review @trxcllnt!

@trxcllnt trxcllnt merged commit 0375a94 into rapidsai:branch-25.08 May 23, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants