update cuda delegate resource free pipeline for safety and segfault-free #14905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) [ghstack-poisoned]
This was referenced Oct 8, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14905
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit ab1c5c1 with merge base f32e9fc ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 8, 2025
Gasoonjia
added a commit
that referenced
this pull request
Oct 8, 2025
This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) ghstack-source-id: 314867937 Pull Request resolved: #14905
This PR needs a
|
meta-cla
bot
added
the
CLA Signed
larryliu0820
reviewed
Oct 8, 2025
| // We noticed that AOTInductorModelContainerDelete doesn't work well with | ||
| // mutitple .so files when we tried to use it to delete container handle, | ||
| // since freeing one of them will free some sharing resources, leading to | ||
| // segfault when trying to free the other .so files. Now we do not explicted |
There was a problem hiding this comment.
You can let AI proofread these.
Suggested change
| // segfault when trying to free the other .so files. Now we do not explicted | |
| // segfault when trying to free the other .so files. Now we do not explicitly |
… segfault-free" This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #14905 This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. ghstack-source-id: 314881464 @exported-using-ghexport Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/)
… segfault-free" This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #14905 This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. ghstack-source-id: 314887533 @exported-using-ghexport Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/)
… segfault-free" This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #14905 This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. ghstack-source-id: 314925612 @exported-using-ghexport Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/)
… segfault-free" This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #14905 This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. ghstack-source-id: 314936353 @exported-using-ghexport Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/)
larryliu0820
approved these changes
Oct 8, 2025
… segfault-free" This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Oct 8, 2025
Pull Request resolved: #14905 This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. ghstack-source-id: 314948206 @exported-using-ghexport Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/)
… segfault-free" This diff survives `clear_all_tensors()` function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files. Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) [ghstack-poisoned]
This was referenced Oct 8, 2025
meta-codesync
bot
merged commit 0bbcec0
into
gh/gasoonjia/50/base
134 of 137 checks passed
Gasoonjia
added a commit
that referenced
this pull request
Oct 9, 2025
…ree (#14927) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14905 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/50/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/50/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/49/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/50/orig Differential Revision: [D84135792](https://our.internmc.facebook.com/intern/diff/D84135792/) @diff-train-skip-merge --------- Co-authored-by: gasoonjia <gasoonjia@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff survives
clear_all_tensors()function and enable it during backend destroy stage. Furthermore, we defer the container handle deletion to OS to avoid potential segfault if there's more than one .so files.Differential Revision: D84135792