-
Notifications
You must be signed in to change notification settings - Fork 689
introduce shim layers for cudaguard and cudastreamguard #14902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
### Summary This diff introduces shim layers for CudaGuard and CudaStreamGuard in the Executorch project, which will be further used by cuda-AOTI models for stream/cuda control. The changes include: * Adding a new source file `runtime/shims/cuda_guard.cpp` and header file `runtime/shims/cuda_guard.h` to the `CMakeLists.txt` and `TARGETS` files. * Creating a new test target `aoti_torch_cuda_guard` in the `targets.bzl` file. * Defining the `cuda_guard.h` header file with the necessary includes, namespace definitions, and function declarations. These changes aim to provide a shim layer for CudaGuard, which is responsible for handling CUDA-related functionality in the Executorch runtime. The shim layer will allow for better modularity and maintainability of the codebase. Differential Revision: [D84126634](https://our.internmc.facebook.com/intern/diff/D84126634/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14902
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 01c4cfe with merge base f32e9fc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
### Summary This diff introduces shim layers for CudaGuard and CudaStreamGuard in the Executorch project, which will be further used by cuda-AOTI models for stream/cuda control. The changes include: * Adding a new source file `runtime/shims/cuda_guard.cpp` and header file `runtime/shims/cuda_guard.h` to the `CMakeLists.txt` and `TARGETS` files. * Creating a new test target `aoti_torch_cuda_guard` in the `targets.bzl` file. * Defining the `cuda_guard.h` header file with the necessary includes, namespace definitions, and function declarations. These changes aim to provide a shim layer for CudaGuard, which is responsible for handling CUDA-related functionality in the Executorch runtime. The shim layer will allow for better modularity and maintainability of the codebase. Differential Revision: [D84126634](https://our.internmc.facebook.com/intern/diff/D84126634/) [ghstack-poisoned]
Pull Request resolved: #14902 ### Summary This diff introduces shim layers for CudaGuard and CudaStreamGuard in the Executorch project, which will be further used by cuda-AOTI models for stream/cuda control. The changes include: * Adding a new source file `runtime/shims/cuda_guard.cpp` and header file `runtime/shims/cuda_guard.h` to the `CMakeLists.txt` and `TARGETS` files. * Creating a new test target `aoti_torch_cuda_guard` in the `targets.bzl` file. * Defining the `cuda_guard.h` header file with the necessary includes, namespace definitions, and function declarations. These changes aim to provide a shim layer for CudaGuard, which is responsible for handling CUDA-related functionality in the Executorch runtime. The shim layer will allow for better modularity and maintainability of the codebase. ghstack-source-id: 314907961 @exported-using-ghexport Differential Revision: [D84126634](https://our.internmc.facebook.com/intern/diff/D84126634/)
### Summary This diff introduces shim layers for CudaGuard and CudaStreamGuard in the Executorch project, which will be further used by cuda-AOTI models for stream/cuda control. The changes include: * Adding a new source file `runtime/shims/cuda_guard.cpp` and header file `runtime/shims/cuda_guard.h` to the `CMakeLists.txt` and `TARGETS` files. * Creating a new test target `aoti_torch_cuda_guard` in the `targets.bzl` file. * Defining the `cuda_guard.h` header file with the necessary includes, namespace definitions, and function declarations. These changes aim to provide a shim layer for CudaGuard, which is responsible for handling CUDA-related functionality in the Executorch runtime. The shim layer will allow for better modularity and maintainability of the codebase. Differential Revision: [D84126634](https://our.internmc.facebook.com/intern/diff/D84126634/) [ghstack-poisoned]
Pull Request resolved: #14902 ### Summary This diff introduces shim layers for CudaGuard and CudaStreamGuard in the Executorch project, which will be further used by cuda-AOTI models for stream/cuda control. The changes include: * Adding a new source file `runtime/shims/cuda_guard.cpp` and header file `runtime/shims/cuda_guard.h` to the `CMakeLists.txt` and `TARGETS` files. * Creating a new test target `aoti_torch_cuda_guard` in the `targets.bzl` file. * Defining the `cuda_guard.h` header file with the necessary includes, namespace definitions, and function declarations. These changes aim to provide a shim layer for CudaGuard, which is responsible for handling CUDA-related functionality in the Executorch runtime. The shim layer will allow for better modularity and maintainability of the codebase. ghstack-source-id: 314915363 @exported-using-ghexport Differential Revision: [D84126634](https://our.internmc.facebook.com/intern/diff/D84126634/)
### Summary This diff introduces shim layers for CudaGuard and CudaStreamGuard in the Executorch project, which will be further used by cuda-AOTI models for stream/cuda control. The changes include: * Adding a new source file `runtime/shims/cuda_guard.cpp` and header file `runtime/shims/cuda_guard.h` to the `CMakeLists.txt` and `TARGETS` files. * Creating a new test target `aoti_torch_cuda_guard` in the `targets.bzl` file. * Defining the `cuda_guard.h` header file with the necessary includes, namespace definitions, and function declarations. These changes aim to provide a shim layer for CudaGuard, which is responsible for handling CUDA-related functionality in the Executorch runtime. The shim layer will allow for better modularity and maintainability of the codebase. Differential Revision: [D84126634](https://our.internmc.facebook.com/intern/diff/D84126634/) [ghstack-poisoned]
### Summary This diff introduces shim layers for CudaGuard and CudaStreamGuard in the Executorch project, which will be further used by cuda-AOTI models for stream/cuda control. The changes include: * Adding a new source file `runtime/shims/cuda_guard.cpp` and header file `runtime/shims/cuda_guard.h` to the `CMakeLists.txt` and `TARGETS` files. * Creating a new test target `aoti_torch_cuda_guard` in the `targets.bzl` file. * Defining the `cuda_guard.h` header file with the necessary includes, namespace definitions, and function declarations. These changes aim to provide a shim layer for CudaGuard, which is responsible for handling CUDA-related functionality in the Executorch runtime. The shim layer will allow for better modularity and maintainability of the codebase. Differential Revision: [D84126634](https://our.internmc.facebook.com/intern/diff/D84126634/) [ghstack-poisoned]
### Summary This diff introduces shim layers for CudaGuard and CudaStreamGuard in the Executorch project, which will be further used by cuda-AOTI models for stream/cuda control. The changes include: * Adding a new source file `runtime/shims/cuda_guard.cpp` and header file `runtime/shims/cuda_guard.h` to the `CMakeLists.txt` and `TARGETS` files. * Creating a new test target `aoti_torch_cuda_guard` in the `targets.bzl` file. * Defining the `cuda_guard.h` header file with the necessary includes, namespace definitions, and function declarations. These changes aim to provide a shim layer for CudaGuard, which is responsible for handling CUDA-related functionality in the Executorch runtime. The shim layer will allow for better modularity and maintainability of the codebase. Differential Revision: [D84126634](https://our.internmc.facebook.com/intern/diff/D84126634/) [ghstack-poisoned]
0377c9a
into
gh/gasoonjia/47/base
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #14902 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/47/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/47/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/47/orig Differential Revision: [D84126634](https://our.internmc.facebook.com/intern/diff/D84126634/) @diff-train-skip-merge --------- Co-authored-by: gasoonjia <gasoonjia@icloud.com> Co-authored-by: Gasoonjia <gasoonjia@meta.com>
Stack from ghstack (oldest at bottom):
Summary
This diff introduces shim layers for CudaGuard and CudaStreamGuard in the Executorch project, which will be further used by cuda-AOTI models for stream/cuda control. The changes include:
runtime/shims/cuda_guard.cpp
and header fileruntime/shims/cuda_guard.h
to theCMakeLists.txt
andTARGETS
files.aoti_torch_cuda_guard
in thetargets.bzl
file.cuda_guard.h
header file with the necessary includes, namespace definitions, and function declarations.These changes aim to provide a shim layer for CudaGuard, which is responsible for handling CUDA-related functionality in the Executorch runtime. The shim layer will allow for better modularity and maintainability of the codebase.
Differential Revision: D84126634