Skip to content

refactor cuda_backend.cpp #14904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 9, 2025
Merged

refactor cuda_backend.cpp #14904

merged 8 commits into from
Oct 9, 2025

Conversation

Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Oct 8, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:

  1. Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
  2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.

Differential Revision: D84135844

@Gasoonjia
refactor cuda_backend.cpp
59a20ff 
This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:
1.  Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.

Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14904

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f60bb93 with merge base f32e9fc (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 8, 2025
Merged
Merged
Merged
Closed
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2025
larryliu0820
larryliu0820 reviewed Oct 8, 2025
View reviewed changes
backends/cuda/runtime/cuda_backend.cpp
// Remove the temporary shared library file
if (!handle->so_path.empty()) {
std::error_code remove_error;
std::filesystem::remove(handle->so_path, remove_error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't delete this line

@Gasoonjia
Update on "refactor cuda_backend.cpp"
f7292fe 
This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:
1.  Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.

Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Oct 8, 2025
@Gasoonjia
refactor cuda_backend.cpp
4591884 
Pull Request resolved: #14904

This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:
1.  Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.
ghstack-source-id: 314877738
@exported-using-ghexport

Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)
@Gasoonjia
Update on "refactor cuda_backend.cpp"
8361ceb 
This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:
1.  Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.

Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)

[ghstack-poisoned]
larryliu0820
larryliu0820 reviewed Oct 8, 2025
View reviewed changes
backends/cuda/runtime/cuda_backend.cpp Outdated
}
ET_CHECK_OR_RETURN_ERROR(
aoti_cuda_buffer.ok(),
aoti_cuda_buffer.error(),
Copy link
Contributor

@larryliu0820 larryliu0820 Oct 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failed to compile because it's returning a AOTI error not a ET error

@Gasoonjia
Update on "refactor cuda_backend.cpp"
202fb2a 
This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:
1.  Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.

Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)

[ghstack-poisoned]
@Gasoonjia
Update on "refactor cuda_backend.cpp"
f1c35bf 
This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:
1.  Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.

Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)

[ghstack-poisoned]
@Gasoonjia
Update on "refactor cuda_backend.cpp"
4021d39 
This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:
1.  Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.

Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)

[ghstack-poisoned]
@Gasoonjia
Update on "refactor cuda_backend.cpp"
ec87078 
This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:
1.  Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.

Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)

[ghstack-poisoned]
@Gasoonjia
Update on "refactor cuda_backend.cpp"
f60bb93 
This diff does a comprehensive refactor on cuda_backend.cpp. Two main points:
1.  Reuse ExecuTorch standard macros (ET_CHECK_OR_RETURN_ERROR and others) to replaces exiting if..else + ET_LOG branches
2. Introduced LOAD_SYMBOL macro to concentrate the symbol loading pipeline.

Differential Revision: [D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)

[ghstack-poisoned]
This was referenced Oct 8, 2025
Merged
Merged
@meta-codesync meta-codesync bot merged commit 6418645 into gh/gasoonjia/49/base Oct 9, 2025
135 of 137 checks passed
@meta-codesync meta-codesync bot deleted the gh/gasoonjia/49/head branch October 9, 2025 05:04
@meta-codesync meta-codesync bot temporarily deployed to cherry-pick-bot October 9, 2025 05:04 Inactive
@pytorchbot pytorchbot mentioned this pull request Oct 9, 2025
Merged
Gasoonjia added a commit that referenced this pull request Oct 9, 2025
@pytorchbot @Gasoonjia
refactor cuda_backend.cpp (#14926)
7722509 
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #14904 by
@Gasoonjia
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/49/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/49/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/47/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/49/orig
Differential Revision:
[D84135844](https://our.internmc.facebook.com/intern/diff/D84135844/)
@diff-train-skip-merge

---------

Co-authored-by: gasoonjia <gasoonjia@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gasoonjia @larryliu0820