Skip to content

Adding new method: DRVI #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

seohyonkim
Copy link

@seohyonkim seohyonkim commented Jun 2, 2025

Describe your changes

This is a PR to add a new method, DRVI into the batch integration tasks.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@mumichae mumichae self-requested a review June 2, 2025 13:54
Copy link
Collaborator

@mumichae mumichae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I flagged some redundant preprocessing code in the script that shouldn't be part of this module

@seohyonkim seohyonkim marked this pull request as draft June 2, 2025 14:35
@mumichae mumichae marked this pull request as ready for review June 2, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants