Update OpentelemetryOban to use semantic conventions 1.27 #5
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
force-pushed
the
main
branch
5 times, most recently
from
8e44b54 to
ed19de1
Compare
danschultzer
force-pushed
the
oban-v1.27-semantics
branch
from
fda7ab9 to
3315c26
Compare
danschultzer
force-pushed
the
main
branch
12 times, most recently
from
97371ab to
d549221
Compare
danschultzer
force-pushed
the
oban-v1.27-semantics
branch
from
3315c26 to
7169e4d
Compare
danschultzer
force-pushed
the
oban-v1.27-semantics
branch
from
7169e4d to
70ab4ef
Compare
danschultzer
force-pushed
the
oban-v1.27-semantics
branch
from
70ab4ef to
1990282
Compare
danschultzer
force-pushed
the
main
branch
2 times, most recently
from
37edcd4 to
a8381b0
Compare
danschultzer
force-pushed
the
oban-v1.27-semantics
branch
from
1990282 to
a7eb053
Compare
|
any reason this can't be merged? |
|
Hey @danschultzer have you received any feedback on this PR outside of this thread? Can this be merged? |
|
@danschultzer Would be lovely to have this merged and released if possible, since I'm not currently able to use opentelemetry_oban because of this issue. |
|
@danschultzer adding myself to the chain kindly asking to merge this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from open-telemetry/opentelemetry-erlang-contrib#435
We have to override the
:semantic_conversionsdep because oban requires~> 0.2but most otel libraries here uses 1.27.Resolves open-telemetry/opentelemetry-erlang-contrib#428