Skip to content

Conversation

@danschultzer
Copy link
Member

@danschultzer danschultzer commented Apr 2, 2025

Port from open-telemetry/opentelemetry-erlang-contrib#437

Stacked on top of #5


Oban triggers a lot of the ecto otel spans. I think we should set up spans for all internal events so we can have oban parent spans for these ecto spans.

The span names is just the telemetry event joined with ., e.g. oban.peer.election. Maybe there is a better convention for span names for these internal processes, or there may be some these telemetry events that should have a specific span names (and attributes).

I've also changed the telemetry handler id, I usually see tuples being used rather than binary.

Sidenote: I think a good future refactor would be to combine all the handlers into just one module instead, I don't think it is necessary to have this concept of Handler.attach vs just calling attach_many with all the oban events we want to listen to.

@danschultzer danschultzer force-pushed the trace-all-oban-events-with-ecto branch from b6fdbb5 to 123e511 Compare April 7, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants