Skip to content

Conversation

@danschultzer
Copy link
Member

@danschultzer danschultzer commented Apr 2, 2025

Port from open-telemetry/opentelemetry-erlang-contrib#436

Stacked on top of #5

Follows the guideslines set out in https://github.com/open-telemetry/semantic-conventions/blob/v1.27.0/docs/messaging/messaging-spans.md#destinations

This does introduce a bunch of breaking changes so let me know if backwards compability is required. I can keep the old attributes, but not sure if we should just go with major release instead since there's a lot of things that are different now? Same question as in #430

Changes

  • messaging.destination -> messaging.consumer.group.name
  • messaging.destination.kind is removed
  • Span names {destination} {operation} changed to{operation} {destination}
  • Span names {plugin} process changed to oban.plugin {plugin}
  • Span names Oban bulk insert changed to {operation} or {operation} {destination} depending whether all are the same job type

Added

  • messaging.destination.name (the worker module)
  • messaging.operation.name
  • messaging.operation.type
  • messaging.message.id

There's also more to this to get it to be compliant with 1.27 conventions. A larger one is that we probably need to deal with creation context? https://github.com/open-telemetry/semantic-conventions/blob/v1.27.0/docs/messaging/messaging-spans.md#context-propagation


Related #367

@danschultzer danschultzer force-pushed the update-oban-attributes branch from 7118b86 to c9f7bca Compare April 7, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants