Skip to content

feat(core): add nx console messaging to TUI #31148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 14, 2025

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented May 9, 2025

Current Behavior

There is no communication between Nx CLI and Nx Console

Expected Behavior

This enables a connection between the Nx TUI app and Nx Console so that we can send messages to console. This is used to update MCP tools on Nx Console to assist with LLMs

Related Issue(s)

Fixes #

Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 13, 2025 10:16pm

Copy link

nx-cloud bot commented May 9, 2025

View your CI Pipeline Execution ↗ for commit 587ccb5.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 10m 57s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-13 22:29:43 UTC

Copy link

github-actions bot commented May 9, 2025

Failed to publish a PR release of this pull request, triggered by @Cammisuli.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/14928166172

@Cammisuli Cammisuli force-pushed the feature/nxa-112-tui-ai-assistance branch from 6820ac2 to f475a11 Compare May 9, 2025 15:18
Copy link

github-actions bot commented May 9, 2025

Failed to publish a PR release of this pull request, triggered by @Cammisuli.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/14932376186

@Cammisuli Cammisuli force-pushed the feature/nxa-112-tui-ai-assistance branch from 4c3bd8a to 572053e Compare May 9, 2025 16:18
Copy link

github-actions bot commented May 9, 2025

Failed to publish a PR release of this pull request, triggered by @Cammisuli.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/14933160481

Copy link

github-actions bot commented May 9, 2025

Failed to publish a PR release of this pull request, triggered by @Cammisuli.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/14933654336

@Cammisuli Cammisuli force-pushed the feature/nxa-112-tui-ai-assistance branch from 817d52f to 05f858f Compare May 9, 2025 17:19
@Cammisuli Cammisuli changed the base branch from master to cammisuli/update-rust-to-2024 May 9, 2025 17:19
@Cammisuli Cammisuli force-pushed the feature/nxa-112-tui-ai-assistance branch 2 times, most recently from 9525149 to aacc95a Compare May 9, 2025 17:46
Copy link

github-actions bot commented May 9, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-31148-817d52f my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-31148-817d52f
Release details 📑
Published version 0.0.0-pr-31148-817d52f
Triggered by @Cammisuli
Branch feature/nxa-112-tui-ai-assistance
Commit 817d52f
Workflow run 14933654336

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@Cammisuli Cammisuli force-pushed the cammisuli/update-rust-to-2024 branch from 0dc8a95 to 01708fd Compare May 9, 2025 20:07
@Cammisuli Cammisuli force-pushed the feature/nxa-112-tui-ai-assistance branch from aacc95a to e5c0eb5 Compare May 9, 2025 20:08
@Cammisuli Cammisuli force-pushed the feature/nxa-112-tui-ai-assistance branch from 8261e9b to d4a1827 Compare May 13, 2025 14:44
@Cammisuli Cammisuli force-pushed the feature/nxa-112-tui-ai-assistance branch from d4a1827 to d063c0f Compare May 13, 2025 15:00
@Cammisuli Cammisuli force-pushed the cammisuli/update-rust-to-2024 branch from 01708fd to 7b778de Compare May 13, 2025 15:00
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-31148-d063c0f my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-31148-d063c0f
Release details 📑
Published version 0.0.0-pr-31148-d063c0f
Triggered by @Cammisuli
Branch feature/nxa-112-tui-ai-assistance
Commit d063c0f
Workflow run 15000272071

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-31148-de3e81b my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-31148-de3e81b
Release details 📑
Published version 0.0.0-pr-31148-de3e81b
Triggered by @Cammisuli
Branch feature/nxa-112-tui-ai-assistance
Commit de3e81b
Workflow run 15006225668

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@Cammisuli Cammisuli force-pushed the cammisuli/update-rust-to-2024 branch from 7b778de to 91afe69 Compare May 13, 2025 21:17
@Cammisuli Cammisuli force-pushed the feature/nxa-112-tui-ai-assistance branch from de3e81b to 77df785 Compare May 13, 2025 21:17
Base automatically changed from cammisuli/update-rust-to-2024 to master May 13, 2025 22:11
@Cammisuli Cammisuli force-pushed the feature/nxa-112-tui-ai-assistance branch from 77df785 to 587ccb5 Compare May 13, 2025 22:14
@Cammisuli Cammisuli marked this pull request as ready for review May 13, 2025 22:14
@Cammisuli Cammisuli requested review from a team, FrozenPandaz and vsavkin as code owners May 13, 2025 22:14
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-31148-587ccb5 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-31148-587ccb5
Release details 📑
Published version 0.0.0-pr-31148-587ccb5
Triggered by @Cammisuli
Branch feature/nxa-112-tui-ai-assistance
Commit 587ccb5
Workflow run 15007779287

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

.and_then(|c| c.start_running_tasks());
}
Action::Tick => {
self.console_messenger.as_ref().and_then(|messenger| {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we throttle/debounce in some way? Updating everything on every tick is quite intense, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can we add some more logs in the happy path when messages are being send to console?

@Cammisuli
Copy link
Member Author

Please can we add some more logs in the happy path when messages are being send to console?

Logs do show up when messages are sent. They're part of the underlying jsonrpsee crate. Like this:
image

@FrozenPandaz FrozenPandaz merged commit 81ecb22 into master May 14, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the feature/nxa-112-tui-ai-assistance branch May 14, 2025 19:58
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants