Skip to content

chore(core): update rust to 2024 edition #31156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented May 9, 2025

Current Behavior

Currently using 2021 edition of rust

Expected Behavior

Updates to 2024 edition to support more features that are coming in other PRs

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested review from a team, FrozenPandaz and vsavkin as code owners May 9, 2025 17:11
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 13, 2025 9:20pm

Copy link

nx-cloud bot commented May 9, 2025

View your CI Pipeline Execution ↗ for commit 91afe69.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 30m 31s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 6m 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-13 21:59:16 UTC

@Cammisuli Cammisuli requested a review from AgentEnder as a code owner May 9, 2025 17:47
@Cammisuli Cammisuli force-pushed the cammisuli/update-rust-to-2024 branch from 0dc8a95 to 01708fd Compare May 9, 2025 20:07
@JamesHenry
Copy link
Collaborator

I've triggered a PR release given this changes native building concerns

Copy link

Failed to publish a PR release of this pull request, triggered by @JamesHenry.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/14954113021

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release failed

@Cammisuli
Copy link
Member Author

Cammisuli commented May 12, 2025

The release failed

This release needs to be triggered from this branch as there are changes in the publish workflow. I've already did a release with these changes here:
#31148 (comment)

But I retriggered a release for this PR to use the right branch, just so that we are 100% sure 😄

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-31156-01708fd my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-31156-01708fd
Release details 📑
Published version 0.0.0-pr-31156-01708fd
Triggered by @Cammisuli
Branch cammisuli/update-rust-to-2024
Commit 01708fd
Workflow run 14974599939

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@Cammisuli Cammisuli force-pushed the cammisuli/update-rust-to-2024 branch from 01708fd to 7b778de Compare May 13, 2025 15:00
Cammisuli added 2 commits May 13, 2025 17:13
chore(core): run cargo fmt for 2024 edition

chore(core): update wasm bindings
@Cammisuli Cammisuli force-pushed the cammisuli/update-rust-to-2024 branch from 7b778de to 91afe69 Compare May 13, 2025 21:17
@FrozenPandaz FrozenPandaz merged commit 889dee0 into master May 13, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the cammisuli/update-rust-to-2024 branch May 13, 2025 22:11
FrozenPandaz pushed a commit that referenced this pull request May 16, 2025
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Currently using 2021 edition of rust

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Updates to 2024 edition to support more features that are coming in
other PRs

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 889dee0)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants