-
Notifications
You must be signed in to change notification settings - Fork 2.5k
chore(core): update rust to 2024 edition #31156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
View your CI Pipeline Execution ↗ for commit 91afe69.
☁️ Nx Cloud last updated this comment at |
0dc8a95
to
01708fd
Compare
I've triggered a PR release given this changes native building concerns |
Failed to publish a PR release of this pull request, triggered by @JamesHenry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release failed
This release needs to be triggered from this branch as there are changes in the publish workflow. I've already did a release with these changes here: But I retriggered a release for this PR to use the right branch, just so that we are 100% sure 😄 |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-31156-01708fd my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-31156-01708fd
To request a new release for this pull request, mention someone from the Nx team or the |
01708fd
to
7b778de
Compare
chore(core): run cargo fmt for 2024 edition chore(core): update wasm bindings
7b778de
to
91afe69
Compare
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Currently using 2021 edition of rust ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Updates to 2024 edition to support more features that are coming in other PRs ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 889dee0)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Currently using 2021 edition of rust
Expected Behavior
Updates to 2024 edition to support more features that are coming in other PRs
Related Issue(s)
Fixes #