chore(core): remove setup function and redundant environment variable clearing

Author: Cammisuli

packages/nx/src/native/tui/nx_console.rs

@@ -74,17 +74,9 @@ fn get_env_var<'a>(name: &str, env_map: &'a mut HashMap<String, String>) -> Opti
 mod tests {
     use super::*;
     use std::collections::HashMap;
-    use std::env;
-
-    fn setup() {
-        // Clear relevant environment variables before each test
-        env::remove_var("TERM_PROGRAM");
-        env::remove_var("VSCODE_GIT_ASKPASS_NODE");
-    }
 
     #[test]
     fn test_detect_vscode() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "vscode".to_string());
         test_env.insert(
@@ -96,7 +88,6 @@ mod tests {
 
     #[test]
     fn test_detect_cursor() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "vscode".to_string());
         test_env.insert(
@@ -108,7 +99,6 @@ mod tests {
 
     #[test]
     fn test_detect_windsurf() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "vscode".to_string());
         test_env.insert(
@@ -120,21 +110,13 @@ mod tests {
 
     #[test]
     fn test_detect_jetbrains() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "jetbrains".to_string());
         assert_eq!(detect_editor(test_env), SupportedEditor::JetBrains);
     }
 
-    #[test]
-    fn test_term_program_missing() {
-        setup();
-        assert_eq!(detect_editor(HashMap::new()), SupportedEditor::Unknown);
-    }
-
     #[test]
     fn test_term_program_unknown() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert(
             "TERM_PROGRAM".to_string(),
@@ -145,7 +127,6 @@ mod tests {
 
     #[test]
     fn test_vscode_without_askpass_confirmation() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "vscode".to_string());
         // No VSCODE_GIT_ASKPASS_NODE set or doesn't contain "vscode"
@@ -154,7 +135,6 @@ mod tests {
 
     #[test]
     fn test_vscode_with_wrong_askpass() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "vscode".to_string());
         test_env.insert(
@@ -166,7 +146,6 @@ mod tests {
 
     #[test]
     fn test_case_insensitivity() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "VSCode".to_string());
         test_env.insert(
@@ -178,7 +157,6 @@ mod tests {
 
     #[test]
     fn test_cursor_without_askpass_confirmation() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "cursor".to_string());
         // No VSCODE_GIT_ASKPASS_NODE set
@@ -187,7 +165,6 @@ mod tests {
 
     #[test]
     fn test_cursor_with_wrong_askpass() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "cursor".to_string());
         test_env.insert(
@@ -199,7 +176,6 @@ mod tests {
 
     #[test]
     fn test_windsurf_without_askpass_confirmation() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "windsurf".to_string());
         // No VSCODE_GIT_ASKPASS_NODE set
@@ -208,7 +184,6 @@ mod tests {
 
     #[test]
     fn test_windsurf_with_wrong_askpass() {
-        setup();
         let mut test_env = HashMap::new();
         test_env.insert("TERM_PROGRAM".to_string(), "windsurf".to_string());
         test_env.insert(