-
Notifications
You must be signed in to change notification settings - Fork 14.4k
RuntimeLibcalls: Avoid adding ppcf128 calls to non-ppc targets #147656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arsenm
wants to merge
1
commit into
users/arsenm/riscv/start-moving-runtime-libcalls-tablegen
Choose a base branch
from
users/arsenm/runtime-libcalls/only-add-ppcf128-calls-ppc
base: users/arsenm/riscv/start-moving-runtime-libcalls-tablegen
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2025
This was referenced Jul 9, 2025
This was referenced Jul 9, 2025
This was referenced Jul 9, 2025
@llvm/pr-subscribers-backend-hexagon @llvm/pr-subscribers-llvm-selectiondag Author: Matt Arsenault (arsenm) ChangesFilter out PPCF128 calls from the default set, and only add them Full diff: https://github.com/llvm/llvm-project/pull/147656.diff 1 Files Affected:
diff --git a/llvm/include/llvm/IR/RuntimeLibcalls.td b/llvm/include/llvm/IR/RuntimeLibcalls.td
index fabfaf89b5aa0..c9eda9110a9ef 100644
--- a/llvm/include/llvm/IR/RuntimeLibcalls.td
+++ b/llvm/include/llvm/IR/RuntimeLibcalls.td
@@ -1012,15 +1012,21 @@ defvar CompilerRTOnlyInt128Libcalls = [
__mulodi4
];
-defvar DefaultRuntimeLibcallImpls =
- !listremove(!listremove(AllDefaultRuntimeLibcallImpls,
- Int128RTLibcalls),
- CompilerRTOnlyInt128Libcalls);
+defvar DefaultRuntimeLibcallImpls_ppcf128 =
+ !filter(entry, AllDefaultRuntimeLibcallImpls,
+ !match(!cast<string>(entry.Provides), "PPCF128"));
defvar DefaultRuntimeLibcallImpls_f128 =
- !filter(entry, DefaultRuntimeLibcallImpls,
+ !filter(entry, AllDefaultRuntimeLibcallImpls,
!match(!cast<string>(entry.Provides), "_F128"));
+defvar DefaultRuntimeLibcallImpls =
+ !listremove(
+ !listremove(
+ !listremove(AllDefaultRuntimeLibcallImpls, Int128RTLibcalls),
+ CompilerRTOnlyInt128Libcalls),
+ DefaultRuntimeLibcallImpls_ppcf128);
+
defvar DefaultRuntimeLibcallImpls_atomic =
!filter(entry, DefaultRuntimeLibcallImpls,
!match(!cast<string>(entry.Provides), "ATOMIC"));
@@ -1843,6 +1849,7 @@ def PPCSystemLibrary
(sub DefaultRuntimeLibcallImpls, memcpy,
DefaultRuntimeLibcallImpls_f128),
__extendkftf2, __trunctfkf2,
+ DefaultRuntimeLibcallImpls_ppcf128,
LibmF128Libcalls, AIX32Calls, AIX64Calls,
AvailableIf<memcpy, isNotAIX>,
LibcallImpls<(add Int128RTLibcalls), isPPC64>)>;
|
RKSimon
approved these changes
Jul 9, 2025
7f81f86
to
ba16f00
Compare
Filter out PPCF128 calls from the default set, and only add them back to PPC.
5b51c68
to
e0d9420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out PPCF128 calls from the default set, and only add them
back to PPC.