RuntimeLibcalls: Remove table of soft float compare cond codes #146082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
This was referenced Jun 27, 2025
arsenm
requested review from
asb,
asl,
DanielKristofKiss,
dpaoliello,
efriedma-quic,
jurahul,
nigelp-xmos,
nikic,
RKSimon,
rnk,
smithp35 and
topperc
arsenm
force-pushed
the
users/arsenm/msp430/set-libcall-impl-cc-runtime-libcalls
branch
2 times, most recently
from
317e79f to
07fd7a0
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/remove-table-soft-float-compare-types
branch
from
a4d5461 to
4e8ecb3
Compare
arsenm
force-pushed
the
users/arsenm/msp430/set-libcall-impl-cc-runtime-libcalls
branch
from
07fd7a0 to
ca7e199
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/remove-table-soft-float-compare-types
branch
from
4e8ecb3 to
effe1ad
Compare
arsenm
force-pushed
the
users/arsenm/msp430/set-libcall-impl-cc-runtime-libcalls
branch
from
ca7e199 to
38213c6
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/remove-table-soft-float-compare-types
branch
from
effe1ad to
1070967
Compare
arsenm
force-pushed
the
users/arsenm/msp430/set-libcall-impl-cc-runtime-libcalls
branch
from
38213c6 to
e8b5aa1
Compare
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/remove-table-soft-float-compare-types
branch
from
1070967 to
48fcd78
Compare
arsenm
force-pushed
the
users/arsenm/msp430/set-libcall-impl-cc-runtime-libcalls
branch
from
e8b5aa1 to
dc6acab
Compare
Base automatically changed from
users/arsenm/msp430/set-libcall-impl-cc-runtime-libcalls
to
main
July 8, 2025 08:18
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/remove-table-soft-float-compare-types
branch
2 times, most recently
from
0daf2fa to
66fa070
Compare
This was referenced Jul 8, 2025
RKSimon
reviewed
Jul 8, 2025
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/remove-table-soft-float-compare-types
branch
2 times, most recently
from
f06a7b1 to
e31b61b
Compare
This was referenced Jul 9, 2025
RKSimon
approved these changes
Jul 9, 2025
Previously we had a table of entries for every Libcall for the comparison to use against an integer 0 if it was a soft float compare function. This was only relevant to a handful of opcodes, so it was wasteful. Now that we can distinguish the abstract libcall for the compare with the concrete implementation, we can just directly hardcode the comparison against the libcall impl without this configuration system.
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/remove-table-soft-float-compare-types
branch
from
e31b61b to
1391620
Compare
arsenm
deleted the
users/arsenm/runtime-libcalls/remove-table-soft-float-compare-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a table of entries for every Libcall for
the comparison to use against an integer 0 if it was a soft
float compare function. This was only relevant to a handful of
opcodes, so it was wasteful. Now that we can distinguish the
abstract libcall for the compare with the concrete implementation,
we can just directly hardcode the comparison against the libcall
impl without this configuration system.