Skip to content

Conversation

@eoinfennessy
Copy link
Member

What this PR does / why we need it:

Adds an example notebook to accompany kubeflow/sdk#13, which introduces the LocalTrainerClient.

Signed-off-by: Eoin Fennessy <efenness@redhat.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15469191274

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.807%

Totals Coverage Status
Change from base Build 15465054454: 0.0%
Covered Lines: 840
Relevant Lines: 2916

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this Sep 23, 2025
@andreyvelich
Copy link
Member

@szaher @eoinfennessy @kramaranya Please can someone finalize this PR to add example for local TrainerClient?
/reopen

@google-oss-prow google-oss-prow bot reopened this Sep 23, 2025
@google-oss-prow
Copy link

@andreyvelich: Reopened this PR.

In response to this:

@szaher @eoinfennessy @kramaranya Please can someone finalize this PR to add example for local TrainerClient?
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreyvelich
Copy link
Member

/milestone v2.1

@google-oss-prow google-oss-prow bot added this to the v2.1 milestone Sep 24, 2025
@kramaranya
Copy link
Contributor

Closing this PR since @briangallagher has opened #2869
/close

@google-oss-prow google-oss-prow bot closed this Oct 3, 2025
@google-oss-prow
Copy link

@kramaranya: Closed this PR.

In response to this:

Closing this PR since @briangallagher has opened #2869
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants