Skip to content

Conversation

@eoinfennessy
Copy link
Member

@eoinfennessy eoinfennessy commented Jun 5, 2025

What this PR does / why we need it:

This PR introduces LocalTrainerClient to the Python SDK. This client implements the same interface as the existing TrainerClient, and enables users to run training jobs in Docker containers, without requiring a Kubernetes cluster.

Old PR: kubeflow/trainer#2610

Accompanying PR adding example notebook: kubeflow/trainer#2658

Which issue(s) this PR fixes

Fixes #2

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Eoin Fennessy <efenness@redhat.com>
@eoinfennessy eoinfennessy force-pushed the add-local-execution-mode branch from 8552865 to 86b0aa2 Compare June 5, 2025 10:01
Signed-off-by: Eoin Fennessy <efenness@redhat.com>
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@franciscojavierarceo
Copy link

@andreyvelich @szaher is this PR still relevant?

@kramaranya
Copy link
Contributor

@andreyvelich @szaher is this PR still relevant?

Nope, @briangallagher is going to create a new one for both Docker and Podman implementations

@andreyvelich
Copy link
Member

This PR is implemented in: #33
/close

@google-oss-prow
Copy link

@andreyvelich: Closed this PR.

In response to this:

This PR is implemented in: #33
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot closed this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local Execution Mode

4 participants