-
Notifications
You must be signed in to change notification settings - Fork 41
feat(trainer): Introduce LocalTrainerClient
#13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Eoin Fennessy <efenness@redhat.com>
8552865 to
86b0aa2
Compare
Signed-off-by: Eoin Fennessy <efenness@redhat.com>
89849de to
a181db1
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@andreyvelich @szaher is this PR still relevant? |
Nope, @briangallagher is going to create a new one for both Docker and Podman implementations |
|
This PR is implemented in: #33 |
|
@andreyvelich: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR introduces
LocalTrainerClientto the Python SDK. This client implements the same interface as the existingTrainerClient, and enables users to run training jobs in Docker containers, without requiring a Kubernetes cluster.Old PR: kubeflow/trainer#2610
Accompanying PR adding example notebook: kubeflow/trainer#2658
Which issue(s) this PR fixes
Fixes #2
Checklist: