-
Notifications
You must be signed in to change notification settings - Fork 46
Language Persistnet through out the flow #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
Language Persistnet through out the flow #356
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis PR refines the order confirmation websocket bot by rewriting system messages to be more concise and human-friendly, updating descriptions for existing flow functions, and introducing a new "user_busy" flow state with corresponding handlers and node linkage. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/agents/voice/breeze_buddy/workflows/order_confirmation/websocket_bot.py (1)
681-681: Consider refining the phrasing for better clarity.The message has slightly awkward phrasing with "I am here just to" and a run-on sentence structure. Consider making it more natural and grammatically clear.
Apply this diff for a clearer, more natural flow:
- "content": "Thank you for confirming the order. I am here just to confirm your order, for any questions related to the order please refer to the website for more details. Have a good day.", + "content": "Thank you for confirming the order. I'm only here to confirm your order. For any other questions, please refer to the website for more details. Have a good day.",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/agents/voice/breeze_buddy/workflows/order_confirmation/websocket_bot.py(8 hunks)
🔇 Additional comments (3)
app/agents/voice/breeze_buddy/workflows/order_confirmation/websocket_bot.py (3)
541-541: LGTM! More specific cancel_order description.The updated description clarifies that the function should only be called when the customer explicitly asks to cancel, which provides better guidance for the LLM function calling.
Also applies to: 571-571
602-608: LGTM! Good addition of user_busy to order flow.Adding the
user_busyfunction to the order_functions list is a smart improvement. Users can indicate they're busy at any stage of the conversation, not just during the initial greeting. The function is properly integrated with its handler and flow node.
669-669: LGTM! Natural and conversational message updates.The updated task messages across these flow nodes are more direct, human-friendly, and appropriate for a voice agent. The removal of instructional phrasing in favor of natural speech improves the user experience.
Also applies to: 693-693, 705-705, 717-717
813b8f3 to
0f9675b
Compare
dev-proof.wav
Summary by CodeRabbit
New Features
Improvements