Skip to content

Conversation

teyssieuman
Copy link
Contributor

@teyssieuman teyssieuman commented May 8, 2025

🦟 Bug fix

Fixes #1562

Summary

The current lower HFOV angle (0.1 rad / 5.72958°) for a camera is too high compared to the limit in gz_sensors (0.01 rad).
The proposed modification allow angle as narrow ad 0.5° and above.

Corresponding PR in gz-sensors depot : gazebosim/gz-sensors#520

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Fabrice Larribe <693401+teyssieuman@users.noreply.github.com>
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 9, 2025
Signed-off-by: Steve Peters <computersthatmove@gmail.com>
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (ff26247) to head (f93d8a3).
Report is 5 commits behind head on sdf15.

Additional details and impacted files
@@            Coverage Diff             @@
##            sdf15    #1563      +/-   ##
==========================================
+ Coverage   92.52%   92.55%   +0.02%     
==========================================
  Files         139      139              
  Lines       18470    18530      +60     
==========================================
+ Hits        17090    17150      +60     
  Misses       1380     1380              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scpeters
Copy link
Member

@osrf-jenkins run tests please

@iche033 iche033 merged commit f704afa into gazebosim:sdf15 May 16, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Narrow angle camera limit.

3 participants