-
Notifications
You must be signed in to change notification settings - Fork 78
Update CameraSensor.ccAllow HFOV narrower than 0.5° #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrice Larribe <693401+teyssieuman@users.noreply.github.com>
8 tasks
iche033
approved these changes
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@Mergifyio backport gz-sensors8 main |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2025
Signed-off-by: Fabrice Larribe <693401+teyssieuman@users.noreply.github.com> (cherry picked from commit d266990)
9 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2025
Signed-off-by: Fabrice Larribe <693401+teyssieuman@users.noreply.github.com> (cherry picked from commit d266990)
9 tasks
iche033
pushed a commit
that referenced
this pull request
May 10, 2025
Signed-off-by: Fabrice Larribe <693401+teyssieuman@users.noreply.github.com> (cherry picked from commit d266990)
iche033
pushed a commit
that referenced
this pull request
May 10, 2025
Signed-off-by: Fabrice Larribe <693401+teyssieuman@users.noreply.github.com> (cherry picked from commit d266990)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #518
Summary
Allows camera sensor HFOV as narrow as 0.5°, and even bellow.
Test it
Create a camera sensor which an HFOV of 0.5° (~0.0087 rad) and launch a simulation
Corresponding PR in
sdformat
: gazebosim/sdformat#1563Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.