Drop Eq requirement on UploadableFile #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sigh unrelated clippy lints, I already fixed that in the bump-deps PR |
sjoerdsimons
force-pushed
the
wip/refi64/uploadable-file-no-eq
branch
from
81ccaed to
2ced5d7
Compare
refi64
force-pushed
the
wip/refi64/uploadable-file-no-eq
branch
3 times, most recently
from
17d11e2 to
7e2005a
Compare
|
(rebased on latest main) |
|
@refi64 with the latest update it seems reasonable to me; can you do a semver (prerealese) bump for Cargo as welland then it's ready to merge |
|
@sjoerdsimons done |
This isn't actually used anywhere in the runner code, and it can be rather annoying to comply with if you need to manually implement it due to holding non-Eq fields (e.g. storing a `File` inline on the struct).
sjoerdsimons
force-pushed
the
wip/refi64/uploadable-file-no-eq
branch
from
77e1e06 to
74a008c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't actually used anywhere in the runner code, and it can be rather annoying to comply with if you need to manually implement it due to holding non-Eq fields (e.g. storing a
Fileinline on the struct).