Skip to content

Commit 3f4e694

Browse files
authored
Drop Eq requirement on UploadableFile (#93)
This isn't actually used anywhere in the runner code, and it can be rather annoying to comply with if you need to manually implement it due to holding non-Eq fields (e.g. storing a `File` inline on the struct).
2 parents da8bd6b + 74a008c commit 3f4e694

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

gitlab-runner/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "gitlab-runner"
3-
version = "0.2.0"
3+
version = "0.3.0-rc1"
44
authors = ["Sjoerd Simons <sjoerd@collabora.com>"]
55
edition = "2021"
66
license = "MIT OR Apache-2.0"

gitlab-runner/examples/demo-runner.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ impl Run {
135135
}
136136
}
137137

138-
#[derive(PartialEq, Eq)]
139138
enum DemoFile {
140139
ReadMe,
141140
Fact { index: usize, value: String },

gitlab-runner/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ pub use client::Phase;
6060
/// `get_path` method is required so that the globbing Gitlab expects
6161
/// can be performed without the handler needing to be involved.
6262
#[async_trait::async_trait]
63-
pub trait UploadableFile: Eq {
63+
pub trait UploadableFile {
6464
/// The type of the data stream returned by
6565
/// [`get_data`](Self::get_data)
6666
type Data<'a>: AsyncRead + Send + Unpin

0 commit comments

Comments
 (0)