Skip to content

Drop Eq requirement on UploadableFile #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gitlab-runner/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "gitlab-runner"
version = "0.2.0"
version = "0.3.0-rc1"
authors = ["Sjoerd Simons <sjoerd@collabora.com>"]
edition = "2021"
license = "MIT OR Apache-2.0"
Expand Down
1 change: 0 additions & 1 deletion gitlab-runner/examples/demo-runner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ impl Run {
}
}

#[derive(PartialEq, Eq)]
enum DemoFile {
ReadMe,
Fact { index: usize, value: String },
Expand Down
2 changes: 1 addition & 1 deletion gitlab-runner/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ pub use client::Phase;
/// `get_path` method is required so that the globbing Gitlab expects
/// can be performed without the handler needing to be involved.
#[async_trait::async_trait]
pub trait UploadableFile: Eq {
pub trait UploadableFile {
/// The type of the data stream returned by
/// [`get_data`](Self::get_data)
type Data<'a>: AsyncRead + Send + Unpin
Expand Down