Generalize workflow system. #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apognu
added
enhancement
apognu
force-pushed
the
feat/advanced-workflows
branch
3 times, most recently
from
14ea632 to
e7162c8
Compare
|
We need the migration to convert the old column-based workflows into the new system. Luckily, it should be quite straightforward side there weren't lots of options. |
apognu
force-pushed
the
feat/advanced-workflows
branch
2 times, most recently
from
f6000c8 to
4fac571
Compare
|
FYI @siiick @Pascal-Delange. |
apognu
force-pushed
the
feat/advanced-workflows
branch
3 times, most recently
from
88fc4ef to
786c597
Compare
apognu
force-pushed
the
feat/advanced-workflows
branch
5 times, most recently
from
86440db to
214dc58
Compare
| "github.com/google/uuid" | ||
| ) | ||
|
|
||
| type Workflow struct { |
There was a problem hiding this comment.
pure naming thing but to be in line with my understanding of what we want to call them, how about workflow=>workflowRule and workflowRule=>workflowRuleMetadata in this file ?
apognu
force-pushed
the
feat/advanced-workflows
branch
2 times, most recently
from
0f6c919 to
1351cbe
Compare
apognu
force-pushed
the
feat/advanced-workflows
branch
2 times, most recently
from
fc47410 to
93f037e
Compare
siiick
force-pushed
the
feat/advanced-workflows
branch
from
93f037e to
a0970b0
Compare
Before this commit, workflows would only perform the actions listed under the first matching rule. While this is still the default, a new option on a rule, `fallthrough`, allows defining that workflow evaluation should continue even if this rules matches. All the actions of of the matching rules up until the first failing or not-fallthrough rule will be executed, in order. As we can only add a decision to a case once, only the first action of this kind will be executed, the other ones will be noops.
…io rule versions.
apognu
force-pushed
the
feat/advanced-workflows
branch
from
1b06474 to
01080c3
Compare
Pascal-Delange
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the decision workflow feature to make it more expandable and useful. It allows the user to create an ordered series of
ruleson a scenario, of which the first one whichconditionsall evaluate to true will execute allactions.This first version does not implement any further actions than those that were already there, so we have
CREATE_CASEandADD_TO_CASE_IF_POSSIBLEand three conditions,always,neverandoutcome_in.So far, it only implement actual executions, not the management API or any kind of validation for the conditions and actions.
Outstanding TODOs: