Skip to content

Generalize workflow system. #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions api/handle_scenarios.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,3 +157,20 @@ func validateScenarioAst(uc usecases.Usecases) func(c *gin.Context) {
})
}
}

func listLatestScenarioRules(uc usecases.Usecases) gin.HandlerFunc {
return func(c *gin.Context) {
ctx := c.Request.Context()
scenarioId := c.Param("scenario_id")

scenarioUsecase := usecasesWithCreds(ctx, uc).NewScenarioUsecase()

rules, err := scenarioUsecase.ListLatestRules(ctx, scenarioId)

if presentError(ctx, c, err) {
return
}

c.JSON(http.StatusOK, pure_utils.Map(rules, dto.AdaptScenarioRuleLatestVersion))
}
}
347 changes: 347 additions & 0 deletions api/handle_workflows.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,347 @@
package api

import (
"net/http"

"github.com/checkmarble/marble-backend/dto"
"github.com/checkmarble/marble-backend/models"
"github.com/checkmarble/marble-backend/pure_utils"
"github.com/checkmarble/marble-backend/usecases"
"github.com/gin-gonic/gin"
"github.com/google/uuid"
)

type ScenarioWorkflowParams struct {
ScenarioId dto.UriUuid `uri:"scenarioId"`
}

type WorkflowRuleParams struct {
RuleId dto.UriUuid `uri:"ruleId"`
Id dto.UriUuid `uri:"id"`
}

func handleListWorkflowsForScenario(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var uri ScenarioWorkflowParams

if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

rules, err := workflowUsecase.ListWorkflowsForScenario(ctx, uri.ScenarioId.Uuid())
if presentError(ctx, c, err) {
return
}

c.JSON(http.StatusOK, pure_utils.Map(rules, dto.AdaptWorkflow))
}
}

func handleCreateWorkflowRule(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var payload dto.CreateWorkflowRuleDto

if err := c.ShouldBindJSON(&payload); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

params := models.WorkflowRule{
ScenarioId: payload.ScenarioId,
Name: payload.Name,
Fallthrough: *payload.Fallthrough,
}

rule, err := workflowUsecase.CreateWorkflowRule(ctx, params)
if presentError(ctx, c, err) {
return
}

c.JSON(http.StatusCreated, dto.AdaptWorkflowRule(rule))
}
}

func handleUpdateWorkflowRule(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var (
uri WorkflowRuleParams
payload dto.UpdateWorkflowRuleDto
)

if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}
if err := c.ShouldBindJSON(&payload); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

params := models.WorkflowRule{
Id: uri.RuleId.Uuid(),
Name: payload.Name,
Fallthrough: *payload.Fallthrough,
}

rule, err := workflowUsecase.UpdateWorkflowRule(ctx, params)
if presentError(ctx, c, err) {
return
}

c.JSON(http.StatusOK, dto.AdaptWorkflowRule(rule))
}
}

func handleDeleteWorkflowRule(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var uri WorkflowRuleParams

if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

if err := workflowUsecase.DeleteWorkflowRule(ctx, uri.RuleId.Uuid()); presentError(ctx, c, err) {
return
}

c.Status(http.StatusNoContent)
}
}

func handleCreateWorkflowCondition(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var (
uri WorkflowRuleParams
payload dto.PostWorkflowConditionDto
)

if err := c.ShouldBindJSON(&payload); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}
if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

params := models.WorkflowCondition{
RuleId: uri.RuleId.Uuid(),
Function: payload.Function,
Params: payload.Params,
}

condition, err := workflowUsecase.CreateWorkflowCondition(ctx, params)
if presentError(ctx, c, err) {
return
}

c.JSON(http.StatusCreated, dto.AdaptWorkflowCondition(condition))
}
}

func handleUpdateWorkflowCondition(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var (
uri WorkflowRuleParams
payload dto.PostWorkflowConditionDto
)

if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}
if err := c.ShouldBindJSON(&payload); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

params := models.WorkflowCondition{
Id: uri.Id.Uuid(),
RuleId: uri.RuleId.Uuid(),
Function: payload.Function,
Params: payload.Params,
}

condition, err := workflowUsecase.UpdateWorkflowCondition(ctx, params)
if presentError(ctx, c, err) {
return
}

c.JSON(http.StatusOK, dto.AdaptWorkflowCondition(condition))
}
}

func handleDeleteWorkflowCondition(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var uri WorkflowRuleParams

if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

if err := workflowUsecase.DeleteWorkflowCondition(ctx, uri.RuleId.Uuid(), uri.Id.Uuid()); presentError(ctx, c, err) {
return
}

c.Status(http.StatusNoContent)
}
}

func handleCreateWorkflowAction(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var (
uri WorkflowRuleParams
payload dto.PostWorkflowActionDto
)

if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}
if err := c.ShouldBindJSON(&payload); presentError(ctx, c, err) {
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

params := models.WorkflowAction{
RuleId: uri.RuleId.Uuid(),
Action: payload.Action,
Params: payload.Params,
}

action, err := workflowUsecase.CreateWorkflowAction(ctx, params)
if presentError(ctx, c, err) {
return
}

c.JSON(http.StatusCreated, dto.AdaptWorkflowAction(action))
}
}

func handleUpdateWorkflowAction(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var (
uri WorkflowRuleParams
payload dto.PostWorkflowActionDto
)

if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}
if err := c.ShouldBindJSON(&payload); presentError(ctx, c, err) {
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

params := models.WorkflowAction{
Id: uri.Id.Uuid(),
RuleId: uri.RuleId.Uuid(),
Action: payload.Action,
Params: payload.Params,
}

action, err := workflowUsecase.UpdateWorkflowAction(ctx, params)
if presentError(ctx, c, err) {
return
}

c.JSON(http.StatusOK, dto.AdaptWorkflowAction(action))
}
}

func handleDeleteWorkflowAction(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var uri WorkflowRuleParams

if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

if err := workflowUsecase.DeleteWorkflowAction(ctx, uri.RuleId.Uuid(), uri.Id.Uuid()); presentError(ctx, c, err) {
return
}

c.Status(http.StatusNoContent)
}
}

func handleReorderWorkflowRules(uc usecases.Usecases) func(c *gin.Context) {
return func(c *gin.Context) {
ctx := c.Request.Context()

var (
uri ScenarioWorkflowParams
ids []uuid.UUID
)

if err := c.ShouldBindUri(&uri); presentError(ctx, c, err) {
c.Status(http.StatusBadRequest)
return
}
if err := c.ShouldBindJSON(&ids); presentError(ctx, c, err) {
return
}

uc := usecasesWithCreds(ctx, uc)
workflowUsecase := uc.NewWorkflowUsecase()

if err := workflowUsecase.ReorderWorkflowRules(ctx, uri.ScenarioId.Uuid(), ids); presentError(ctx, c, err) {
return
}

c.Status(http.StatusNoContent)
}
}
13 changes: 13 additions & 0 deletions api/routes.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ func addRoutes(r *gin.Engine, conf Configuration, uc usecases.Usecases, auth uti
router.GET("/scenarios/:scenario_id", tom, getScenario(uc))
router.PATCH("/scenarios/:scenario_id", tom, updateScenario(uc))
router.POST("/scenarios/:scenario_id/validate-ast", tom, validateScenarioAst(uc))
router.GET("/scenarios/:scenario_id/rules/latest", tom, listLatestScenarioRules(uc))

router.GET("/scenario-iterations", tom, handleListScenarioIterations(uc))
router.POST("/scenario-iterations", tom, handleCreateScenarioIteration(uc))
Expand Down Expand Up @@ -296,4 +297,16 @@ func addRoutes(r *gin.Engine, conf Configuration, uc usecases.Usecases, auth uti
router.DELETE("/webhooks/:webhook_id", tom, handleDeleteWebhook(uc))

router.GET("/rule-snoozes/:rule_snooze_id", tom, handleGetSnoozesById(uc))

router.GET("/workflows/:scenarioId", tom, handleListWorkflowsForScenario(uc))
router.POST("/workflows/:scenarioId/reorder", tom, handleReorderWorkflowRules(uc))
router.POST("/workflows/rule", tom, handleCreateWorkflowRule(uc))
router.PUT("/workflows/rule/:ruleId", tom, handleUpdateWorkflowRule(uc))
router.DELETE("/workflows/rule/:ruleId", tom, handleDeleteWorkflowRule(uc))
router.POST("/workflows/rule/:ruleId/condition", tom, handleCreateWorkflowCondition(uc))
router.PUT("/workflows/rule/:ruleId/condition/:id", tom, handleUpdateWorkflowCondition(uc))
router.DELETE("/workflows/rule/:ruleId/condition/:id", tom, handleDeleteWorkflowCondition(uc))
router.POST("/workflows/rule/:ruleId/action", tom, handleCreateWorkflowAction(uc))
router.PUT("/workflows/rule/:ruleId/action/:id", tom, handleUpdateWorkflowAction(uc))
router.DELETE("/workflows/rule/:ruleId/action/:id", tom, handleDeleteWorkflowAction(uc))
}
Loading