Allow DISABLED workflow action and add endpoint to list latest scenario rule versions.

Author: apognu

api/handle_scenarios.go

@@ -157,3 +157,20 @@ func validateScenarioAst(uc usecases.Usecases) func(c *gin.Context) {
 		})
 	}
 }
+
+func listLatestScenarioRules(uc usecases.Usecases) gin.HandlerFunc {
+	return func(c *gin.Context) {
+		ctx := c.Request.Context()
+		scenarioId := c.Param("scenario_id")
+
+		scenarioUsecase := usecasesWithCreds(ctx, uc).NewScenarioUsecase()
+
+		rules, err := scenarioUsecase.ListLatestRules(ctx, scenarioId)
+
+		if presentError(ctx, c, err) {
+			return
+		}
+
+		c.JSON(http.StatusOK, pure_utils.Map(rules, dto.AdaptScenarioRuleLatestVersion))
+	}
+}

api/routes.go

@@ -98,6 +98,7 @@ func addRoutes(r *gin.Engine, conf Configuration, uc usecases.Usecases, auth uti
 	router.GET("/scenarios/:scenario_id", tom, getScenario(uc))
 	router.PATCH("/scenarios/:scenario_id", tom, updateScenario(uc))
 	router.POST("/scenarios/:scenario_id/validate-ast", tom, validateScenarioAst(uc))
+	router.GET("/scenarios/:scenario_id/rules/latest", tom, listLatestScenarioRules(uc))
 
 	router.GET("/scenario-iterations", tom, handleListScenarioIterations(uc))
 	router.POST("/scenario-iterations", tom, handleCreateScenarioIteration(uc))

dto/scenarios.go

@@ -101,3 +101,19 @@ func AdaptUpdateScenarioInput(scenarioId string, input UpdateScenarioBody) model
 	}
 	return parsedInput
 }
+
+type ScenarioRuleLatestVersion struct {
+	Type          string `json:"type"`
+	StableId      string `json:"stable_id"`
+	Name          string `json:"name"`
+	LatestVersion string `json:"latest_version"`
+}
+
+func AdaptScenarioRuleLatestVersion(rule models.ScenarioRuleLatestVersion) ScenarioRuleLatestVersion {
+	return ScenarioRuleLatestVersion{
+		Type:          rule.Type,
+		StableId:      rule.StableId,
+		Name:          rule.Name,
+		LatestVersion: rule.LatestVersion,
+	}
+}

mocks/scenario_repository_mock.go

@@ -41,3 +41,13 @@ func (s *ScenarioRepository) UpdateScenario(ctx context.Context, exec repositori
 	args := s.Called(exec, scenario)
 	return args.Error(0)
 }
+
+func (s *ScenarioRepository) ListScenarioLatestRuleVersions(ctx context.Context, exec repositories.Executor, scenarioId string) ([]models.ScenarioRuleLatestVersion, error) {
+	args := s.Called(ctx, exec, scenarioId)
+
+	if args.Error(1) != nil {
+		return nil, args.Error(1)
+	}
+
+	return args.Get(0).([]models.ScenarioRuleLatestVersion), nil
+}

models/scenarios.go

@@ -72,3 +72,10 @@ type ScenarioAndIteration struct {
 	Scenario  Scenario
 	Iteration ScenarioIteration
 }
+
+type ScenarioRuleLatestVersion struct {
+	Type          string
+	StableId      string
+	Name          string
+	LatestVersion string
+}

repositories/dbmodels/db_scenario.go

@@ -58,3 +58,10 @@ func AdaptScenario(dto DBScenario) (models.Scenario, error) {
 
 	return scenario, nil
 }
+
+type DBScenarioRuleLatestVersion struct {
+	Type         string `db:"type"`
+	StableRuleId string `db:"stable_rule_id"`
+	Name         string `db:"name"`
+	Version      string `db:"version"`
+}

repositories/scenarios_read.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/checkmarble/marble-backend/models"
 	"github.com/checkmarble/marble-backend/repositories/dbmodels"
+	"github.com/jackc/pgx/v5"
 
 	"github.com/Masterminds/squirrel"
 )
@@ -24,6 +25,7 @@ type ScenarioUsecaseRepository interface {
 		exec Executor,
 		scenario models.UpdateScenarioInput,
 	) error
+	ListScenarioLatestRuleVersions(ctx context.Context, exec Executor, scenarioId string) ([]models.ScenarioRuleLatestVersion, error)
 }
 
 func selectScenarios() squirrel.SelectBuilder {
@@ -78,3 +80,56 @@ func (repo *MarbleDbRepository) ListAllScenarios(ctx context.Context, exec Execu
 		dbmodels.AdaptScenario,
 	)
 }
+
+func (repo *MarbleDbRepository) ListScenarioLatestRuleVersions(ctx context.Context, exec Executor, scenarioId string) ([]models.ScenarioRuleLatestVersion, error) {
+	sql := `
+		select type, stable_rule_id, name, version
+		from (
+			select
+				rank() over (partition by sir.stable_rule_id order by si.version desc) as rank,
+				'rule' as type,
+				sir.stable_rule_id,
+				sir.name,
+				si.version
+			from scenario_iteration_rules sir
+			inner join scenario_iterations si on si.id = sir.scenario_iteration_id
+			where si.scenario_id = $1
+			union all
+			select
+				rank() over (partition by scc.stable_id order by si.version desc) as rank,
+				'screening' as type,
+				scc.stable_id,
+				scc.name,
+				si.version
+			from sanction_check_configs scc
+			inner join scenario_iterations si on si.id = scc.scenario_iteration_id
+			where si.scenario_id = $2
+		) rules
+		where rules.rank = 1
+		order by rules.version desc, rules.name asc
+	`
+
+	rows, err := exec.Query(ctx, sql, scenarioId, scenarioId)
+	if err != nil {
+		return nil, err
+	}
+
+	rules := make([]models.ScenarioRuleLatestVersion, 0)
+
+	for rows.Next() {
+		rule, err := pgx.RowToStructByName[dbmodels.DBScenarioRuleLatestVersion](rows)
+
+		if err != nil {
+			return nil, err
+		}
+
+		rules = append(rules, models.ScenarioRuleLatestVersion{
+			Type:          rule.Type,
+			StableId:      rule.StableRuleId,
+			Name:          rule.Name,
+			LatestVersion: rule.Version,
+		})
+	}
+
+	return rules, nil
+}

usecases/scenario_usecase.go

@@ -199,3 +199,16 @@ func (usecase *ScenarioUsecase) CreateScenario(
 	})
 	return createdScenario, nil
 }
+
+func (uc *ScenarioUsecase) ListLatestRules(ctx context.Context, scenarioId string) ([]models.ScenarioRuleLatestVersion, error) {
+	scenario, err := uc.repository.GetScenarioById(ctx, uc.executorFactory.NewExecutor(), scenarioId)
+	if err != nil {
+		return nil, err
+	}
+
+	if err := uc.enforceSecurity.ReadScenario(scenario); err != nil {
+		return nil, err
+	}
+
+	return uc.repository.ListScenarioLatestRuleVersions(ctx, uc.executorFactory.NewExecutor(), scenarioId)
+}

usecases/workflows_usecase.go

@@ -380,6 +380,8 @@ func (uc *WorkflowUsecase) ValidateWorkflowAction(ctx context.Context, scenario
 					"invalid AST in field 'title_template'")
 			}
 		}
+	case models.WorkflowDisabled:
+		return nil
 	default:
 		return errors.Wrapf(models.BadParameterError, "unknown workflow action type: %s", cond.Action)
 	}