Allow linux users manipulate wm_class and wm_instance of windows

crates/bevy_internal/Cargo.toml

@@ -48,8 +48,8 @@ filesystem_watcher = ["bevy_asset/filesystem_watcher"]
 serialize = ["bevy_input/serialize"]
 
 # Display server protocol support (X11 is enabled by default)
-wayland = ["bevy_winit/wayland"]
-x11 = ["bevy_winit/x11"]
+wayland = ["bevy_winit/wayland", "bevy_window/wayland"]
+x11 = ["bevy_winit/x11", "bevy_window/x11"]
 
 # enable rendering of font glyphs using subpixel accuracy
 subpixel_glyph_atlas = ["bevy_text/subpixel_glyph_atlas"]

crates/bevy_window/Cargo.toml

@@ -8,6 +8,10 @@ repository = "https://github.com/bevyengine/bevy"
 license = "MIT OR Apache-2.0"
 keywords = ["bevy"]
 
+[features]
+wayland = []
+x11 = []
+
 [dependencies]
 # bevy
 bevy_app = { path = "../bevy_app", version = "0.8.0-dev" }
@@ -20,3 +24,6 @@ raw-window-handle = "0.4.2"
 
 [target.'cfg(target_arch = "wasm32")'.dependencies]
 web-sys = "0.3"
+
+[package.metadata.docs.rs]
+features = ["x11"]

crates/bevy_window/src/window.rs

@@ -594,6 +594,10 @@ pub struct WindowDescriptor {
     pub resize_constraints: WindowResizeConstraints,
     pub scale_factor_override: Option<f64>,
     pub title: String,
+    #[cfg(any(feature = "x11", feature = "wayland"))]
+    pub desktop_id: String,
+    #[cfg(feature = "x11")]
+    pub desktop_instance: String,
     #[doc(alias = "vsync")]
     pub present_mode: PresentMode,
     pub resizable: bool,
@@ -617,6 +621,10 @@ impl Default for WindowDescriptor {
     fn default() -> Self {
         WindowDescriptor {
             title: "app".to_string(),
+            #[cfg(any(feature = "x11", feature = "wayland"))]
+            desktop_id: "app".to_string(),
+            #[cfg(feature = "x11")]
+            desktop_instance: "Main".to_string(),
             width: 1280.,
             height: 720.,
             position: None,

crates/bevy_winit/src/winit_windows.rs

@@ -4,6 +4,17 @@ use bevy_window::{Window, WindowDescriptor, WindowId, WindowMode};
 use raw_window_handle::HasRawWindowHandle;
 use winit::dpi::LogicalSize;
 
+#[cfg(all(
+    any(
+        target_os = "linux",
+        target_os = "freebsd",
+        target_os = "netbsd",
+        target_os = "openbsd"
+    ),
+    any(feature = "x11", feature = "wayland")
+))]
+use winit::platform::unix::WindowBuilderExtUnix;
+
 #[derive(Debug, Default)]
 pub struct WinitWindows {
     pub windows: HashMap<winit::window::WindowId, winit::window::Window>,
@@ -102,6 +113,46 @@ impl WinitWindows {
         #[allow(unused_mut)]
         let mut winit_window_builder = winit_window_builder.with_title(&window_descriptor.title);
 
+        #[allow(unused_mut)]
+        #[cfg(all(
+            any(
+                target_os = "linux",
+                target_os = "freebsd",
+                target_os = "netbsd",
+                target_os = "openbsd"
+            ),
+            feature = "x11"
+        ))]
+        let mut winit_window_builder = winit_window_builder.with_class(
+            window_descriptor.desktop_instance.clone(), // that's actually wm_instance
+            window_descriptor.desktop_id.clone(),       // and that's wm_class
+        );
+        /*
+        https://github.com/rust-windowing/winit/blob/ea1c031b54438e64576353b288848c07d2068214/src/platform/unix.rs#L337
+        337|    fn with_class(self, class: String, instance: String) -> Self;
+        https://github.com/rust-windowing/winit/blob/ea1c031b54438e64576353b288848c07d2068214/src/platform/unix.rs#L383
+        383|    fn with_class(mut self, instance: String, class: String) -> Self {
+
+        Because of type equality someone wrote those wrong and Rust didn't catch it!
+        rust-analyser uses only trait declaration, therefore it shows wrong parameter names
+
+        This bug persists not only in 0.26.0, but also in 0.26.1
+        The next update will be breaking, no more differentiation between x11 class and wayland appid
+        */
+
+        #[allow(unused_mut)]
+        #[cfg(all(
+            any(
+                target_os = "linux",
+                target_os = "freebsd",
+                target_os = "netbsd",
+                target_os = "openbsd"
+            ),
+            feature = "wayland"
+        ))]
+        let mut winit_window_builder =
+            winit_window_builder.with_app_id(window_descriptor.desktop_id.clone());
+
         #[cfg(target_arch = "wasm32")]
         {
             use wasm_bindgen::JsCast;