-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Extract text colors per glyph #20245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ickshonpe
wants to merge
12
commits into
bevyengine:main
Choose a base branch
from
ickshonpe:extract-text-color-per-glyph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Extract text colors per glyph #20245
ickshonpe
wants to merge
12
commits into
bevyengine:main
from
ickshonpe:extract-text-color-per-glyph
+74
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract text colors per glyph.
Moved `Transform` from `ExtractedUiItem` to `ExtractedUiNode`.
mogambro
reviewed
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
A-Text
Rendering and layout for characters
A-UI
Graphical user interfaces, styles, layouts, and widgets
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Colors are extracted per text section, transforms per glyph.
This makes it awkward to set colors for individual glyphs as they have to be batched separately.
Solution
color: LinearRgba
andtranslation: Vec2
fields toExtractedGlyph
.transform
fields fromExtractedGlyph
andExtractedUiItem
toExtractedUiNode
.rect
field fromExtractedUiNode
toExtractedUiItem
.ExtractedUiNode
s are smaller by 16 bytes, from 208 to 192 bytes in size.ExtractedGlyph
s are smaller by 8 bytes, from 48 to 40 bytes in size.Testing
Output from the UI examples should be unchanged, main ones to check are
testbed_ui
,testbed_full_ui
,text_debug
,text_wrap_debug
andui_transform
.Not a performance motivated change but this should show a marginal improvement over main, YMMV: