Refactor actions cache to be build on main #20144
Open
+309
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
force-pushed
the
refactor-actions-cache
branch
from
3389f8b to
f893744
Compare
alice-i-cecile
added
A-Build-System
SkiFire13
approved these changes
Jul 15, 2025
.github/workflows/ci.yml
Outdated
Comment on lines
35
to
39
| # key won't match, will rely on restore-keys | ||
| key: ${{ runner.os }}-stable--${{ hashFiles('**/Cargo.toml') }}- | ||
| restore-keys: | | ||
| ${{ runner.os }}-stable--${{ hashFiles('**/Cargo.toml') }}- | ||
| ${{ runner.os }}-stable-- |
There was a problem hiding this comment.
Just a nit: I would document that these have to follow the keys in update-caches.yml
BD103
suggested changes
Jul 15, 2025
Comment on lines
+130
to
+131
| path: | | ||
| ~/.cargo/bin/ |
There was a problem hiding this comment.
In the future, we should look into caching ~/.cargo/.crates.toml and ~/.cargo/.crates2.json, as they track which executables were installed with cargo install. Not something we need to do now, though, since we don't install anything with cargo install :)
BD103
added
S-Waiting-on-Author
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
BD103
approved these changes
Jul 15, 2025
mockersf
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution