Move Window creation from plugin build time to PreStartup #20019
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhohenheim
added
A-Windowing
janhohenheim
commented
Jul 7, 2025
| entity_commands.insert(primary_cursor_options.clone()); | ||
| } | ||
| let primary_window = primary_window.clone(); | ||
| let primary_cursor_options = self.primary_cursor_options.clone().unwrap_or_default(); |
There was a problem hiding this comment.
This is the same behavior as before because CursorOptions is a required component of Window
IceSentry
approved these changes
Jul 7, 2025
janhohenheim
added
the
X-Contentious
janhohenheim
added
S-Waiting-on-Author
|
Blocking until we figure out why this even works even though |
This reverts commit f6c8db4.
janhohenheim
added
the
S-Blocked
|
Blocked by #20021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Windowcomponent for more granular change detection #19644Windowby observer instead of by plugin fields #20018Our
PrimaryWindowand its associatedWindoware currently spawned on plugin build time, hence making it very hard to write an observer for them likeOn<Add, PrimaryWindow>Solution
PreStartup. Using that schedule instead ofStartupbecause the latter is more user-facing, and the user should not have to know about the details of when exactly the window is created. It should just exist.Testing
Additional Info
If all goes well, this change should make no difference to the user whatsoever.