Prevent TOCTOU bugs in ComponentsQueuedRegistrator

[SkiFire13]

Objective

• Fix ComponentsQueuedRegistrator::queue_register_component does not ensure components are registered only once #20014

Solution

• Don't make the force_register_ family of functions always enqueue of the component/resource; instead have them check again whether it was already queued or not.

Testing

• I added a small regression test but it's non-deterministic: if the bug is fixed it will always pass, but if the bug is presen then it has a (hopefully small) chance of passing. On my PC it failed after ~100 iterations, so hopefully 1000 is enough in CI (assuming it doesn't have single core runners...)

[chescock]

Good catch!

[chescock]

Why remove force from the names? They're still queuing without first checking that the components are registered, which is a kind of "forcing".

The names queue_register_component and register_arbitrary_component don't do a great job of communicating the difference, although I suppose force_register_arbitrary_component wasn't much better.

Hmm, I wonder if it would make sense to make a future PR to inline these into their callers so that we don't need two names.

[SkiFire13]

I see your point, but at the same time they are no longer really forcing the registration. They are more like register_if_not_enqueued or something like that, but it doesn't sound so good as a name.

[JaySpruce]

Suggested change

	/// Queues this function to run as a resource registratorif the given
	/// Queues this function to run as a resource registrator if the given