Skip to content

Use RenderStartup for bevy_pbr for some basic cases. #19999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use RenderStartup for bevy_pbr for some basic cases. #19999

wants to merge 3 commits into from

Conversation

andriyDev
Copy link
Contributor

Objective

Solution

  • For cases that don't need to conditionally add systems, we can just replace FromWorld impls with systems and then add those systems to RenderStartup.

Testing

  • I ran the lightmaps, reflection_probes, deferred_rendering, volumetric_fog, and wireframe examples.

@andriyDev andriyDev added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 7, 2025
@andriyDev andriyDev added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Jul 7, 2025
@andriyDev andriyDev requested a review from atlv24 July 7, 2025 18:59
@andriyDev andriyDev force-pushed the startup-pbr-basic branch 2 times, most recently from 0bacb15 to 7a5917c Compare July 9, 2025 00:10
atlv24
atlv24 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@atlv24 atlv24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

god this is so good

@atlv24 atlv24 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 9, 2025
@andriyDev andriyDev force-pushed the startup-pbr-basic branch from 7a5917c to de75755 Compare July 10, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@atlv24 atlv24 atlv24 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andriyDev @IceSentry @atlv24