Fix require components depth

[SkiFire13]

Note: I suggest reviewing commit-by-commit

Objective

• Fix RequiredComponent.inheritance_depth docs do not matchComponent derive impl #19863
• Clean up a bit how recursive required components registration works

Solution

• Update required components registration to be oblivious of the recursive registration happening.
• Concretely this means removing the requiree, inheritance_depth and recursion_check_stack parameters from Component::register_required_components
  • requiree was effectively unused
  • inheritance_depth is now useless, because the depth is always either 0 (for direct requirements) or computed in register_inherited_required_components by bumping the depth of the inherited components
  • recursion_check_stack has been moved to ComponentsRegistrator, which also allows to make enforce_no_required_components_recursion private.

Testing

• Existing tests pass
• A test has been updated to catch the issue from RequiredComponent.inheritance_depth docs do not matchComponent derive impl #19863

[SkiFire13]

Putting this into draft mode since after a bit more analysis this seems to be the wrong order (it's breath-first-like/lower-inheritance-depth-preferred but should be depth-first instead)

[alice-i-cecile]

Putting this into draft mode since after a bit more analysis this seems to be the wrong order (it's breath-first-like/lower-inheritance-depth-preferred but should be depth-first instead)

Good catch. We should add more tests to ensure that this is caught.

[SkiFire13]

Good catch. We should add more tests to ensure that this is caught.

The issue is that we also have features that assume a breath-first-like/lower-inheritance-depth-preferred order, and we have tests for them too