-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Move bevy_mikktspace out of tree #19798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I like this direction. Strongly in favor of:
I'd like to get SME-Rendering sign-off, and figure out our publishing strategy. |
I would suggest publishing it at 0.17, letting it sit for a release or two, and if no issues then publishing 1.0 and forgetting about it for the rest of time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty for taking this on!
bushrat had opinions on how to handle no_std/libm stuff and the api surface of it, so i'd like to hear from him before merge |
Seconding Alice's comment that avoiding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely in favour of this direction. I have a PR here which makes the new crate totally independent of std
and even libm
, while also removing about a third of the total Rust code and being (IMO) much easier to read.
Additionally, I have another PR here which removes the binary blobs and all C code, instead using mikktspace-sys
to provide live A/B comparison when in a #[cfg(test)]
environment.
I could pretty easily see the new bevy_mikktspace
hitting 1.0 before the end of the year and just not being worried about possibly ever again.
Glad to see this moving forward 🎉, feel free to ping me on discord (or here) with any questions about my original port or the safe conversion. It's been a while but I'm sure I can still answer the trickier details. |
Objective
Related issues and PRs:
Solution
Testing