Skip to content

PlaneMeshBuilder: allow for different number of subdivisions in X and Z directions #19479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

PlaneMeshBuilder: allow for different number of subdivisions in X and Z directions #19479

wants to merge 3 commits into from
+57 −11

Conversation

Wuketuke
Copy link
Contributor

@Wuketuke Wuketuke commented Jun 3, 2025

Fixes #16437
it was as simple as @ulmer-a suggested
I also adapted the documentation

i havent manually tested if these axis arent switched, but from reading the code it should be fine

@alice-i-cecile alice-i-cecile changed the title Issue 16437 PlaneMeshBuilder: allow for different amounts of subdivisions in X and Z directions Jun 3, 2025
@alice-i-cecile alice-i-cecile changed the title PlaneMeshBuilder: allow for different amounts of subdivisions in X and Z directions PlaneMeshBuilder: allow for different number of subdivisions in X and Z directions Jun 3, 2025
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Math Fundamental domain-agnostic mathematical operations D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon labels Jun 3, 2025
mockersf
mockersf reviewed Jun 3, 2025
View reviewed changes
janhohenheim
janhohenheim approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but IMO this needs a tiiiiny migration guide for people who were setting the subdivisions field directly without using the subdivisions method

@janhohenheim janhohenheim added M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf left review comments

@mweatherley mweatherley mweatherley approved these changes

@janhohenheim janhohenheim janhohenheim approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PlaneMeshBuilder: Different amounts of subdivisions in X and Z directions
5 participants
@Wuketuke @mweatherley @mockersf @janhohenheim @alice-i-cecile