Upgrade cement to 2.10.14/Fix EBCLI for Python 3.12 #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 11, 2024 21:39
This commit remvoes unnecessary code to check whether the right version of docker is present. This was necessary a few years ago when older versions of docker, incompatible with local development, were still in use. This commit also assumes the customer has the necessary setup to launch docker locally on a Windows.
Assume existence of modern pip versions
…t Git branches "main" came into adoption as the default branch on certain Git clients especially on OS X whereas "master" was historically the default branch.
This commit incorporates cement 2.10.14 that removes accesses to the `imp` module in favour of `importlib` for 3.12. The EB CLI now works for Python 3.12. One limitation is that Pytest 3 is not compatible with Python 3.12 because of it's reliance on `imp` and [this change](https://github.com/pytest-dev/pytest/blob/9515dfa58a144f3644fd29b256113d723c9c1955/src/_pytest/config/argparsing.py#L180) not having been incorporated into Pytest 3.10.1 which hasn't see a new release [since Nov 2018](https://pypi.org/project/pytest/3.10.1/). In future work, we should upgrade Pytest to 8.x. Issue: #493
rahulrajaram
changed the title
azpaulp
approved these changes
Sep 13, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade cement to 2.10.14 and upgrade other dependencies. Drop support for Python 2.7 and all Pythons below 3.7. Remove code anticipating older, deprecated versions of Docker.
Undo a past change that parsed .ebextensions and saved configs for ELB parameters which was non-idiomatic since the service is what should be responsible for determining precedence.
Testing: I have run manual tests with several
ebcommands and have ensured that unit tests work against Python 3.12 and 3.9. One thing to be aware of is that Pytest 3 is also incompatible with Python 3.12 due toimpdeprecation and a signature change of theaddinimethod. I've verified that the necessary fixes being made/backported, that all unit tests against Python 3.12 + Pytest 3.10.1. In a future work, we will upgrade pytest to 8.xBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.