feat(psim)!: change a setting parameter type from bool to string #1106

yuki-takagi-66 · 2024-08-02T07:21:04Z

Description

This PR changes a configuration variable from a bool type to a string type to allow more flexibility in configuring the localization module to be activated in psim.
This PR does not change the behavior.

This PR is a part of the following issue, and a new mode will be added in a few weeks.
#1100

universe PR: autowarefoundation/autoware_universe#8331

Tests performed

In psim, we verified that the activated nodes are properly switched.
There was also no problem in executing scenario_sim.
internal link: https://evaluation.tier4.jp/evaluation/reports/bc29eeab-daa3-55e1-8446-400bdb049517?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

autoware_launch/launch/components/tier4_simulator_component.launch.xml

yukkysaito · 2024-08-02T08:34:51Z

autoware_launch/launch/planning_simulator.launch.xml

@@ -81,13 +81,14 @@
    <let name="launch_dummy_perception" value="true" unless="$(var scenario_simulation)"/>
    <let name="launch_dummy_vehicle" value="false" if="$(var scenario_simulation)"/>
    <let name="launch_dummy_vehicle" value="true" unless="$(var scenario_simulation)"/>
-    <let name="launch_dummy_localization" value="true"/>
+    <!-- The following modes are available as localization_sim_mode: nothing, api -->
+    <let name="localization_sim_mode" value="api"/>


How about making the following change and adding <arg name="localization_sim_mode" default="foo" description="none, foo, ..."/> in the Optional parameters section?

Suggested change

<let name="localization_sim_mode" value="api"/>

<let name="localization_sim_mode" value="$(var localization_sim_mode)"/>

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

yuki-takagi-66 · 2024-08-09T04:04:45Z

@mitsudome-r @yukkysaito
Thank you for the suggestions. I have updated the code corresponding to the comments. 93d3715

mitsudome-r · 2024-08-09T04:16:19Z

autoware_launch/launch/planning_simulator.launch.xml

@@ -81,13 +83,13 @@
    <let name="launch_dummy_perception" value="true" unless="$(var scenario_simulation)"/>
    <let name="launch_dummy_vehicle" value="false" if="$(var scenario_simulation)"/>
    <let name="launch_dummy_vehicle" value="true" unless="$(var scenario_simulation)"/>
-    <let name="launch_dummy_localization" value="true"/>
+    <let name="localization_sim_mode" value="$(var localization_sim_mode)"/>


Now that we added localization_sim_mode as arg in the in the same file, I think we can remove this let statement.

Sorry for my poor understanding. Thank you.

yukkysaito

LGTM

TakaHoribe · 2024-08-09T04:22:34Z

autoware_launch/launch/planning_simulator.launch.xml

@@ -37,6 +37,8 @@
  <arg name="enable_all_modules_auto_mode" default="$(var scenario_simulation)" description="enable all module's auto mode"/>
  <!-- Simulated time -->
  <arg name="use_sim_time" default="$(var scenario_simulation)"/>
+  <!-- Localization-->
+  <arg name="localization_sim_mode" default="api" description="select localization mode. none, api"/>


Suggested change

<arg name="localization_sim_mode" default="api" description="select localization mode. none, api"/>

<arg name="localization_sim_mode" default="api" description="select localization mode. Options are 'none' or 'api'. 'api' starts an external API for initial position estimation. 'none' does not start any localization-related process."/>

I've add description. 226f872

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* change a param type, bool to string --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

…owarefoundation#1106) * change a param type, bool to string --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

…autowarefoundation#1106) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat(behavior_path _planner): divide planner manager modules into dependent slots (autowarefoundation#1091) * Revert "fix(api): disable rosbridge to fix duplicated node" (#523) Revert "fix(api): disable rosbridge to fix duplicated node (#497)" This reverts commit 1b04604. * feat(autonomous_emergency_braking): add info marker to aeb and state check override (autowarefoundation#1103) * add info marker and override for state Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * make stop wall viz default Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(lane_change): add param for lateral angle deviation (autowarefoundation#1087) * RT1-6514 adding lateral angle deviation param Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * decrease angle deviation threshold to fix rtc issue Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * feat(lane_change): use different rss param to deal with parked vehicle (autowarefoundation#1104) use separate rss for parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * feat: increase the number of processes monitored by process_monitor (autowarefoundation#1110) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * fix(mpc_lateral_controller): publish predicted trajectory in Frenet coordinate and visualize it on Rviz (autowarefoundation#1111) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(tracking_object_merger): add merge frame (autowarefoundation#1112) * fix(lane_change): skip generating path if longitudinal distance difference is less than threshold (autowarefoundation#1108) add skip process lon dist diff threshold Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * feat(static_obstacle_avoidance): change policy for ambiguous avoidance situation (autowarefoundation#1113) * feat(static_obstacle_avoidance): change policy for ambiguous avoidance situation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(static_obstacle_avoidance): tune ambiguous vehicle ignore area Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(goal_planner): fix lane departure check not working correctly due to uninitialized variable (autowarefoundation#1116) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(psim)!: change a setting parameter type from bool to string (autowarefoundation#1106) * change a param type, bool to string --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * feat(autoware_map_based_prediction): add debug parameters for map-based prediction (autowarefoundation#1118) * feat: add debug parameters for map-based prediction Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(lane_change): parameter update (autowarefoundation#1115) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * feat(psim)!: preapre settings to launch localization modules on psim (autowarefoundation#1094) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * chore(autoware_multi_object_tracker): fix typo in input_channels (autowarefoundation#1121) chore: fix typo of lidar_pointpainitng channel Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix(lidar_model): add centerpoint_sigma param file (autowarefoundation#1086) fix: add centerpoint_sigma param file Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * feat(tier4_perception_launch): add transfusion option for lidar_detection_model (autowarefoundation#1124) Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * feat(freespace_planning_algorithms): add new parameters for astar planning algorithm (autowarefoundation#1120) * add new astar planner parameters Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * add flag for obstacle confidence check Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * reduce freespace planner th_arrived_distance_m param value Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * reduce object polygon expand size in costmap generator Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * reduce vehicle shape margin in freespace planner Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * replace flag param by time threshold param Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * chore(vehicle_cmd_gate): delete deprecated parameters (autowarefoundation#1127) delete deprecated params in vehicle_cmd_gate.param.yaml Signed-off-by: Autumn60 <harada.akiro@gmail.com> * perf(goal_planner): faster path sorting and selection (autowarefoundation#1119) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(static_obstacle_avoidance): add parameter for envelope polygon creation (autowarefoundation#1130) * add threshold for eclipse long radius Signed-off-by: Go Sakayori <gsakayori@gmail.com> * change parameter Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> --------- Signed-off-by: Go Sakayori <gsakayori@gmail.com> Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * refactor(lane_change): rename prepare_segment_ignore_object_velocity_thresh (autowarefoundation#1125) change parameter name to a more expressive one Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * feat(lane_change): consider deceleration in safety check for cancel (autowarefoundation#1068) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(raw_vehicle_cmd_converter): add steer command conversion with VGR (autowarefoundation#1131) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * chore(e2e_launch): add launch_sensing_driver arg (autowarefoundation#1095) * feat(raw_vehicle_cmd_converter): disable actuation to steering (autowarefoundation#1132) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(localization): add lidar_marker_localizer (#861) * add config files Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * style(pre-commit): autofix * add param marker_height_from_ground Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * save log param Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * apply PointXYZIRC Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * to pass spell-check Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * refactor Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * change flag Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * fix typo Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> --------- Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <rgbygscrsedppbwg@gmail.com> * feat(out_of_lane): redesign to improve accuracy and performance (autowarefoundation#1117) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * fix(ekf_localizer): change roll, pitch proc dev (autowarefoundation#1140) change roll, pitch proc dev Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> * feat(obstacle_pointcloud_based_validator): add enable_debugger parameter (autowarefoundation#1123) * feat: add enable debugger parameter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(occupancy_grid_based_outlier_fillter): add config file to autoware_launch (autowarefoundation#1137) * feat: add config file Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(pid_longitudinal_controller)!: add acceleration feedback block (autowarefoundation#1139) * add params --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * feat(detected_object_validation): copy parameter files update from universe (autowarefoundation#1126) feat: copy params from universe Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: fix parameter type error in occupancy_grid_map_outlier_filter.param.yaml (autowarefoundation#1146) * feat: fix parameter type Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore: change param name Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * chore(stop_filter): extract stop_filter.param.yaml to autoware_launch (autowarefoundation#1145) Extract stop_filter.param.yaml to autoware_launch Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * fix(min-velocity-map-based-prediction): reduce min_velocity_for_map_based_prediction (autowarefoundation#994) fix(min-velocity-map-based-prediction): reduce min_velocity_for_map_based_prediction to let intersection module run with low speed npc Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai> * fix(static_obstacle_avoidance): tune parameters (autowarefoundation#1143) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(static_obstacle_avoidance): increase prepare time (autowarefoundation#1148) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(autoware_lidar_transfusion): add transfusion config (autowarefoundation#1093) Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> * feat: add simulator rviz config (autowarefoundation#1150) Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * feat(autoware_launch): add expansion params (autowarefoundation#1133) make expansion optional Signed-off-by: beyza <bnk@leodrive.ai> * chore: add taekjin lee to perception launcher and configuration maintainer (autowarefoundation#1154) chore: add taekjin lee to perception launcher and configuration maintainer Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * feat(autoware_mpc_lateral_controller): add resampled reference trajectory for debug purpose (autowarefoundation#1114) * chore: add debug_publish_resampled_reference_trajectory to parameter Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * feat: add use_delayed_initial_state flag to lateral MPC configuration Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * feat(occupancy_grid_map_outlier_filter): add option for time keeper (autowarefoundation#1147) add timekeeper option Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: Taekjin LEE <technolojin@gmail.com> * feat(ground_segmentation): add option for time keeper (autowarefoundation#1134) add option for time keeper Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: Taekjin LEE <technolojin@gmail.com> * feat(occupancy_grid_map): add option for time keeper (autowarefoundation#1138) * add option for time keeper Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> * set default to false Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> --------- Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: Taekjin LEE <technolojin@gmail.com> * chore(tier4_pereption_component): add image_segmentation_based_filter option param (autowarefoundation#1158) Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * feat(goal_planner): dense goal candidate sampling in BusStopArea (autowarefoundation#1156) * chore(planning): add maintainer (autowarefoundation#1161) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * feat: add parameters for restart suppression in crosswalk (autowarefoundation#1160) * feat: add parameters for restart suppression in crosswalk Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update parameter Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(mission_planner): add option to prevent rerouting in autonomous driving mode (autowarefoundation#1153) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(run_out): speed up run out response (autowarefoundation#1163) speed up run out response Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * feat(start_planner): add option to skip rear vehicle check (autowarefoundation#1165) Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * feat: add an env variable to enable the new rviz2 theme (autowarefoundation#1017) Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * feat(crosswalk)!: update stop position caluculation (autowarefoundation#1162) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * feat: change visualization of localization results from PoseHistory to PoseWithCovarianceHistory (autowarefoundation#1164) * PoseHistory to PoseWithCovarianceHistory Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> * style(pre-commit): autofix * fix param of alpha related to PoseWithCovarianceHistory Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> --------- Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * style(rviz-config): use colors consistent with new theme (autowarefoundation#1169) Signed-off-by: KhalilSelyan <khalil@leodrive.ai> * feat(tier4_perception_launch): enable to use multi camera on traffic light recognition (autowarefoundation#1144) change the way to declare camera num Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> * refactor(behavior_path_planner): remove unnecessary parameters (autowarefoundation#1172) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * refactor(behavior_path_planner): remove unnecessary parameters (autowarefoundation#1172) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * refactor(system_monitor/ntp_monitor): add-missing-parameters (autowarefoundation#1174) refactor: add-missing-parameters Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * refactor(system_monitor/net_monitor): remove-missing-patameters (autowarefoundation#1175) refactor: remove-missing-patameters Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat(emergency_handler): delete package (autowarefoundation#1173) * feat(emergency_handler): delete package Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * fix(avoidance_by_lane_change): remove unused parameter (autowarefoundation#1176) remove unused parameter Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * feat(lane_change): add lane change parameter (autowarefoundation#1157) add parameter to enable/disable bound check Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * refactor(system_monitor/ntp_monitor): add-missing-parameters (autowarefoundation#1174) refactor: add-missing-parameters Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * refactor(system_monitor/net_monitor): remove-missing-patameters (autowarefoundation#1175) refactor: remove-missing-patameters Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat(emergency_handler): delete package (autowarefoundation#1173) * feat(emergency_handler): delete package Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * fix(perception): adopt awsim (tlr) camera topic (autowarefoundation#1177) Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> * revert: feat: change visualization of localization results from PoseHistory to PoseWithCovarianceHistory (autowarefoundation#1164) (autowarefoundation#1179) Revert "feat: change visualization of localization results from PoseHistory to PoseWithCovarianceHistory (autowarefoundation#1164)" This reverts commit 593ad1f. * feat(tier4_perception_launch): enable to use multi camera on traffic light recognition (autowarefoundation#1144) change the way to declare camera num Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> * fix(perception): adopt awsim (tlr) camera topic (autowarefoundation#1177) Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> * feat(system_error_monitor): delete system error monitor (autowarefoundation#1178) feat: delete system error monitor Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat(system_error_monitor): delete system error monitor (autowarefoundation#1178) feat: delete system error monitor Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> * feat(autonomous_emergency_braking): initiate speed_calculation_expansion_margin parameter (autowarefoundation#1168) initiate speed_calculation_expansion_margin parameter Signed-off-by: ismetatabay <ismet@leodrive.ai> * feat(pose_initializer): add new parameter for check error between initial pose and GNSS pose (autowarefoundation#1180) * add pose_error_check_enabled parameter Signed-off-by: RyuYamamoto <ryu.yamamoto@tier4.jp> * change default value Signed-off-by: RyuYamamoto <ryu.yamamoto@tier4.jp> --------- Signed-off-by: RyuYamamoto <ryu.yamamoto@tier4.jp> * fix(obstacle_cruise_planner): tune obstacle_cruise_planner for cruising front NPCs in dense urban ODD scenarios (autowarefoundation#1166) fix(obstacle_cruise_planner): tune obstacle_cruise_planner for cruising front NPCs in dense urban ODD scenarios Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai> * revert(obstacle_cruise): revert an awf change (#617) Revert "fix(obstacle_cruise_planner): tune obstacle_cruise_planner for cruising front NPCs in dense urban ODD scenarios (autowarefoundation#1166)" * feat(autonomous_emergency_braking): set max imu path length (autowarefoundation#1183) * set param for max imu path distance Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * change param Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * chore(crop_box_filter): add missing default parameter (autowarefoundation#1155) fix: add missing parameter after crop_box_filter rework Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * feat(obstacle_cruise_planner): improve stop and cruise behavior for cut-in & out (autowarefoundation#1142) Signed-off-by: Berkay Karaman <berkay@leodrive.ai> * revert(obstacle_cruise): reduce using predicted paths to maintain conventional behavior (#621) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * revert(obstacle_cruisse): revert "fix(obstacle_cruise_planner): guarantee the stop margin (autowarefoundation#1076)" (autowarefoundation#1185) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * Remove emergency braking from autoware-psim.yaml and enable autonomous emergency braking in tier4_control_component.launch.xml Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * refactor(rviz): add VirtualWall display for Autonomous Emergency Braking (autowarefoundation#1187) feat(rviz): add VirtualWall display for Autonomous Emergency Braking Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * chore: sync files (autowarefoundation#1188) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> * fix(.github): change runs-on value to to ubuntu-22.04 (autowarefoundation#1189) change to ubuntu-22.04 Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> * fix(pointcloud_map_filter): add threshold for split map grid size (autowarefoundation#1184) * fix(pointcloud_map_filter): add param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: disable dynamic map loader for default unsplit-map Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> Signed-off-by: Autumn60 <harada.akiro@gmail.com> Signed-off-by: Go Sakayori <gsakayori@gmail.com> Signed-off-by: Go Sakayori <go.sakayori@tier4.jp> Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai> Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> Signed-off-by: KhalilSelyan <khalil@leodrive.ai> Signed-off-by: beyza <bnk@leodrive.ai> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com> Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com> Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp> Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com> Signed-off-by: veqcc <ryuta.kambe@tier4.jp> Signed-off-by: ismetatabay <ismet@leodrive.ai> Signed-off-by: RyuYamamoto <ryu.yamamoto@tier4.jp> Signed-off-by: Berkay Karaman <berkay@leodrive.ai> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Hayato Mizushima <hayato-m126@users.noreply.github.com> Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Kaan Çolak <kaancolak95@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Yuki TAKAGI <141538661+yuki-takagi-66@users.noreply.github.com> Co-authored-by: Taekjin LEE <technolojin@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Co-authored-by: mkquda <168697710+mkquda@users.noreply.github.com> Co-authored-by: Autumn60 <37181352+Autumn60@users.noreply.github.com> Co-authored-by: Go Sakayori <go-sakayori@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Yamato Ando <yamato.ando@gmail.com> Co-authored-by: SakodaShintaro <rgbygscrsedppbwg@gmail.com> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: TaikiYamada4 <129915538+TaikiYamada4@users.noreply.github.com> Co-authored-by: Ahmed Ebrahim <36835765+ahmeddesokyebrahim@users.noreply.github.com> Co-authored-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp> Co-authored-by: Khalil Selyan <36904941+KhalilSelyan@users.noreply.github.com> Co-authored-by: beyzanurkaya <32412808+beyzanurkaya@users.noreply.github.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: Masaki Baba <maumaumaumaumaumaumaumaumaumau@gmail.com> Co-authored-by: SaltUhey <111027815+SaltUhey@users.noreply.github.com> Co-authored-by: Masato Saeki <78376491+MasatoSaeki@users.noreply.github.com> Co-authored-by: TetsuKawa <70682030+TetsuKawa@users.noreply.github.com> Co-authored-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> Co-authored-by: Ismet Atabay <56237550+ismetatabay@users.noreply.github.com> Co-authored-by: RyuYamamoto <ryu.yamamoto@tier4.jp> Co-authored-by: Berkay Karaman <brkay54@gmail.com> Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Hayato Mizushima <hayato-m126@users.noreply.github.com> Co-authored-by: Autumn60 <harada.akiro@gmail.com> Co-authored-by: Autumn60 <Autumn60@users.noreply.github.com>

github-actions bot added component:simulation Virtual environment setups and simulations. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 2, 2024

yuki-takagi-66 mentioned this pull request Aug 2, 2024

feat(psim)!: change a setting parameter type from bool to string autowarefoundation/autoware_universe#8331

Merged

yuki-takagi-66 changed the title ~~feat(psim)!: bool to string~~ feat(psim)!: Change a setting parameter type from bool to string Aug 2, 2024

yuki-takagi-66 mentioned this pull request Aug 2, 2024

Preparing settings to launch localization modules on planning_simulator #1100

Open

3 tasks

yuki-takagi-66 marked this pull request as ready for review August 2, 2024 08:11

yuki-takagi-66 requested review from takayuki5168, rej55, satoshi-ota, shmpwk, yukkysaito, mitsudome-r and xmfcx as code owners August 2, 2024 08:11

yuki-takagi-66 added the run:build-and-test-differential label Aug 2, 2024

yuki-takagi-66 assigned yukkysaito, mitsudome-r and TakaHoribe Aug 2, 2024

mitsudome-r reviewed Aug 2, 2024

View reviewed changes

autoware_launch/launch/components/tier4_simulator_component.launch.xml Show resolved Hide resolved

yukkysaito reviewed Aug 2, 2024

View reviewed changes

yuki-takagi-66 force-pushed the takagi/psim-localization_sim_mode branch from 6f4dabb to 158bb67 Compare August 8, 2024 04:26

yuki-takagi-66 requested review from ito-san, isamu-takagi, tkimura4, danielsanchezaran, kyoichi-sugahara, zulfaqar-azmi-t4, go-sakayori, kosuke55, mkquda and maxime-clem as code owners August 8, 2024 04:26

yuki-takagi-66 requested review from soblin and yhisaki as code owners August 8, 2024 04:26

github-actions bot added component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Aug 8, 2024

yuki-takagi-66 added 3 commits August 9, 2024 13:02

change a param type, bool to string

35ba612

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

change comment

46b8888

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

responce to the review

93d3715

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

yuki-takagi-66 force-pushed the takagi/psim-localization_sim_mode branch from 158bb67 to 93d3715 Compare August 9, 2024 04:03

github-actions bot removed component:system System design and integration. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Aug 9, 2024

mitsudome-r reviewed Aug 9, 2024

View reviewed changes

yukkysaito approved these changes Aug 9, 2024

View reviewed changes

TakaHoribe reviewed Aug 9, 2024

View reviewed changes

add param description, delete unnecessary line

226f872

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

TakaHoribe approved these changes Aug 9, 2024

View reviewed changes

yuki-takagi-66 changed the title ~~feat(psim)!: Change a setting parameter type from bool to string~~ feat(psim)!: change a setting parameter type from bool to string Aug 13, 2024

mitsudome-r approved these changes Aug 13, 2024

View reviewed changes

satoshi-ota approved these changes Aug 14, 2024

View reviewed changes

yuki-takagi-66 merged commit 2167c0b into autowarefoundation:main Aug 14, 2024
13 checks passed

yuki-takagi-66 deleted the takagi/psim-localization_sim_mode branch August 14, 2024 02:58

tier4-autoware-public-bot bot mentioned this pull request Aug 14, 2024

chore: sync awf-latest tier4/autoware_launch#542

Merged

This was referenced Aug 15, 2024

feat(psim)!: preapre settings to launch localization modules on psim autowarefoundation/autoware_universe#8212

Merged

feat(psim)!: preapre settings to launch localization modules on psim #1094

Merged

kyoichi-sugahara pushed a commit that referenced this pull request Aug 19, 2024

feat(psim)!: change a setting parameter type from bool to string (#1106)

69dccf5

* change a param type, bool to string --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request May 1, 2025

feat(start_planner): disable geometric pull out to avoid dry steering (…

7e3371b

…autowarefoundation#1106) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(psim)!: change a setting parameter type from bool to string #1106

feat(psim)!: change a setting parameter type from bool to string #1106

Uh oh!

yuki-takagi-66 commented Aug 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

yukkysaito Aug 2, 2024

Uh oh!

yuki-takagi-66 commented Aug 9, 2024

Uh oh!

mitsudome-r Aug 9, 2024

Uh oh!

yuki-takagi-66 Aug 9, 2024

Uh oh!

yukkysaito left a comment

Uh oh!

TakaHoribe Aug 9, 2024

Uh oh!

yuki-takagi-66 Aug 9, 2024

Uh oh!

Uh oh!

Uh oh!

	<let name="localization_sim_mode" value="api"/>
	<let name="localization_sim_mode" value="$(var localization_sim_mode)"/>

	<arg name="localization_sim_mode" default="api" description="select localization mode. none, api"/>
	<arg name="localization_sim_mode" default="api" description="select localization mode. Options are 'none' or 'api'. 'api' starts an external API for initial position estimation. 'none' does not start any localization-related process."/>

feat(psim)!: change a setting parameter type from bool to string #1106

feat(psim)!: change a setting parameter type from bool to string #1106

Uh oh!

Conversation

yuki-takagi-66 commented Aug 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Tests performed

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

Uh oh!

Uh oh!

yukkysaito Aug 2, 2024

Choose a reason for hiding this comment

Uh oh!

yuki-takagi-66 commented Aug 9, 2024

Uh oh!

mitsudome-r Aug 9, 2024

Choose a reason for hiding this comment

Uh oh!

yuki-takagi-66 Aug 9, 2024

Choose a reason for hiding this comment

Uh oh!

yukkysaito left a comment

Choose a reason for hiding this comment

Uh oh!

TakaHoribe Aug 9, 2024

Choose a reason for hiding this comment

Uh oh!

yuki-takagi-66 Aug 9, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yuki-takagi-66 commented Aug 2, 2024 •

edited

Loading