Skip to content

refactor(motion_velocity_planner): simplify insert stop point function #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maxime-clem
Copy link
Contributor

Description

Minor change to simplify the function to add stop points to the motion velocity planner trajectory.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 14, 2025
@maxime-clem maxime-clem requested review from mkquda, youtalk and a team as code owners April 14, 2025 05:49
Copy link

github-actions bot commented Apr 14, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (4cb18f5) to head (23985a1).
Report is 174 commits behind head on main.

Files with missing lines Patch % Lines
...nner/autoware_motion_velocity_planner/src/node.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #375       +/-   ##
==========================================
- Coverage   78.75%   0.00%   -78.76%     
==========================================
  Files          11     101       +90     
  Lines         193    7079     +6886     
  Branches       73    1279     +1206     
==========================================
- Hits          152       0      -152     
- Misses         11    7079     +7068     
+ Partials       30       0       -30     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ner/src/node.cpp

Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@mitsudome-r
Copy link
Member

Could you explain how this modification is tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants