Skip to content

feat(autoware_adapi_v1_msgs): update diag messages #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

isamu-takagi
Copy link
Collaborator

@isamu-takagi isamu-takagi commented Jun 3, 2025

Description

Update diagnostics API messages to support latch feature.
Related to autowarefoundation/autoware-documentation#674

  • Add leaf status to provide raw diag data.
  • Add input/latch levels for latch feature.

How was this PR tested?

Check build passes.

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Jun 3, 2025
Copy link

github-actions bot commented Jun 3, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Comment on lines +4 to 5
autoware_adapi_v1_msgs/DiagLeafStruct[] diags
autoware_adapi_v1_msgs/DiagLinkStruct[] links
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better for backward compatibility?

Suggested change
autoware_adapi_v1_msgs/DiagLeafStruct[] diags
autoware_adapi_v1_msgs/DiagLinkStruct[] links
autoware_adapi_v1_msgs/DiagLinkStruct[] links
autoware_adapi_v1_msgs/DiagLeafStruct[] diags

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the code perspective there is no difference. From the binary perspective there are no guarantees and there should be no guarantees. For example, if a DiagNodeStruct is changed, compatibility will be lost even if the order is kept.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it added second to maintain alignment with DiagGraphStatus? If there's no guarantee, I'd prefer keeping it at the end to make its addition more obvious.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match the order of fields in DiagGraphStruct and DiagGraphStatus.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 9d0bfd5 into autowarefoundation:main Jun 17, 2025
10 checks passed
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (9bb74bd) to head (3c02a6f).
Report is 32 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #92      +/-   ##
======================================
  Coverage   0.00%     0              
======================================
  Files        501     0     -501     
  Lines      27337     0   -27337     
======================================
+ Misses     27337     0   -27337     
Flag Coverage Δ
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants