feat(autoware_adapi_v1_msgs): add parent field to diag leaf message #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
approved these changes
Jun 19, 2025
youtalk
approved these changes
Jun 19, 2025
sasakisasaki
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
It seems the PR author tested as the attached picture's process (can be accessed via link in this PR's description). I believe the performed tests are certainly using added property parent as these lines (this is the changes that of PR whose link is in this PR's description)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#92 adds leaf status for raw diag, but the link data for diag leaf was incompatible with some applications, so fix it.
How was this PR tested?
autowarefoundation/autoware_universe#10846
Notes for reviewers
None.
Effects on system behavior
None.