Implement RFC 27 amendment: deprecate add_sync_process, not add_process.

[wanda-phi]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05ac367) 87.15% compared to head (14beaa1) 87.16%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
+ Coverage   87.15%   87.16%   +0.01%     
==========================================
  Files          41       41              
  Lines        7427     7420       -7     
  Branches     1767     1765       -2     
==========================================
- Hits         6473     6468       -5     
+ Misses        778      776       -2     
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[whitequark]

I think this is insufficient since we ban yield Settle() in add_process: https://amaranth-lang.org/rfcs/0027-simulator-testbenches.html#guidance-on-simulator-modalities

[wanda-phi]

I think this is insufficient since we ban yield Settle() in add_process: https://amaranth-lang.org/rfcs/0027-simulator-testbenches.html#guidance-on-simulator-modalities

I don't quite understand? Using Settle in add_process raises a deprecation warning right on Settle construction.

[whitequark]

I don't quite understand? Using Settle in add_process raises a deprecation warning right on Settle construction.

Oh sorry, I completely forgot that it's entirely deprecated, that's 100% on me.

[whitequark]

Thank you!