feat: optional shares validation for round trip properties #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daejunpark
changed the title
Collaborator
Author
|
@aviggiano what do you think? also, if this works with your tests, we can add them to ci so that future changes don't break them. |
|
Good! Thanks |
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Aug 4, 2025
### 🕓 Changelog The test library [`erc4626-tests`](https://github.com/a16z/erc4626-tests) introduced the `_skipRoundTripShares` flag in PR [a16z/erc4626-tests#15](a16z/erc4626-tests#15). When set to `true`, it skips the shares inequality assertions in round‑trip tests. The default value is `false`, but since we favour explicitness, we explicitly set `_skipRoundTripShares = false` in the `ERC4626VaultTest` test `setUp` function. Furthermore, this commit pins [`forge-std`](https://github.com/foundry-rs/forge-std) to commit [`369dd01c808c255765b074c12aa420da33947a65`](foundry-rs/forge-std@369dd01) to temporarily prevent CI test failures in the nightly [`halmos`](https://github.com/a16z/halmos)-based tests (see [foundry-rs/forge-std#705](foundry-rs/forge-std#705)). --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
willbrown84
added a commit
to willbrown84/snekmate
that referenced
this pull request
Sep 23, 2025
### 🕓 Changelog The test library [`erc4626-tests`](https://github.com/a16z/erc4626-tests) introduced the `_skipRoundTripShares` flag in PR [a16z/erc4626-tests#15](a16z/erc4626-tests#15). When set to `true`, it skips the shares inequality assertions in round‑trip tests. The default value is `false`, but since we favour explicitness, we explicitly set `_skipRoundTripShares = false` in the `ERC4626VaultTest` test `setUp` function. Furthermore, this commit pins [`forge-std`](https://github.com/foundry-rs/forge-std) to commit [`369dd01c808c255765b074c12aa420da33947a65`](foundry-rs/forge-std@369dd01) to temporarily prevent CI test failures in the nightly [`halmos`](https://github.com/a16z/halmos)-based tests (see [foundry-rs/forge-std#705](foundry-rs/forge-std#705)). --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
void-rider5560p
added a commit
to void-rider5560p/snekmate
that referenced
this pull request
Sep 28, 2025
### 🕓 Changelog The test library [`erc4626-tests`](https://github.com/a16z/erc4626-tests) introduced the `_skipRoundTripShares` flag in PR [a16z/erc4626-tests#15](a16z/erc4626-tests#15). When set to `true`, it skips the shares inequality assertions in round‑trip tests. The default value is `false`, but since we favour explicitness, we explicitly set `_skipRoundTripShares = false` in the `ERC4626VaultTest` test `setUp` function. Furthermore, this commit pins [`forge-std`](https://github.com/foundry-rs/forge-std) to commit [`369dd01c808c255765b074c12aa420da33947a65`](foundry-rs/forge-std@369dd01) to temporarily prevent CI test failures in the nightly [`halmos`](https://github.com/a16z/halmos)-based tests (see [foundry-rs/forge-std#705](foundry-rs/forge-std#705)). --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Changes:
_skipRoundTripSharesflag: Skip shares inequality assertions in round trip tests when set to truecheckNoFreeProfitmodifierWhy?
Some vault implementations have specific behaviors that cause shares comparison assertions to fail, even though the vault is otherwise correct. This flag allows testing such vaults while still preventing free profit extraction.