🥢 Set _skipRoundTripShares Flag in ERC4626VaultTest
#336
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
…947a65` Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
…466cf1` Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
…947a65` Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🕓 Changelog
The test library
erc4626-testsintroduced the_skipRoundTripSharesflag in PR a16z/erc4626-tests#15. When set totrue, it skips the shares inequality assertions in round‑trip tests. The default value isfalse, but since we favour explicitness, we explicitly set_skipRoundTripShares = falsein theERC4626VaultTesttestsetUpfunction. Furthermore, this PR pinsforge-stdto commit369dd01c808c255765b074c12aa420da33947a65to temporarily prevent CI test failures in the nightlyhalmos-based tests (see foundry-rs/forge-std#705).🐶 Cute Animal Picture